Skip to content

Doxygen: move device/driver under to components #10336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025

Conversation

unicornx
Copy link
Contributor

@unicornx unicornx commented May 29, 2025

和源码的布局保持一致,Device-Driver 子模块应该属于 components 下。文档的布局也相应做出调整。

调整前:我们看到 Guide 部分和 Module 部分的 Device/Driver 都是独立在 Components 之外的。而且名字还不统一,一个叫 Device,一个叫 ”RTTHREAD Driver‘
image

调整后: Guide 部分和 Module 部分以统一的名字 ”Device Driver“ 放在 Components 下一级。
image

文件改动貌似很多,但逻辑比较直接,为了方便 review,这个 PR 由三个 commit 组成:

  • “doxygen: change group_Device to group_device_driver”:原先定义的 group_Device 实际上应该属于 device-driver 组件的一部分,所以新建一个 group_device_driver, 然后将 group_Device 更名为 group_device_driver

  • “doxygen: change group_Drivers to group_device_driver”:原先定义的 "group_Drivers" 实际上应该属于 device-driver 组件的一部分,所以将 "group_Drivers" 更名为 "group_device_driver"。这样原先的 “group_Device" 和 ”group_Drivers" 就合并为 "group_device_driver"。
    同时调整了 driver 代码中的 doxygen 注释的写法,统一为:

     * @defgroup    group_XXX XXX
     * @brief       xxxxxx
     * @ingroup     group_device_driver
  • “doxygen: move device_driver under to components for pages”:doxygen Module 部分已经调整完毕,这个提交是修改了 markdown 文档部分,也将 device-driver 的 page 移到 components 下。

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

unicornx added 3 commits May 29, 2025 10:00
The originally defined "group_Device" should actually
be part of the device-driver component, so create
a new "group_device_driver" and then rename
"group_Device" to "group_device_driver".

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
The originally defined "group_Drivers" should actually
be part of the device-driver component, so
"group_Drivers" is renamed to "group_device_driver".

In this way, the original "group_Device" and
"group_Drivers" are merged into "group_device_driver".

Adjusted the writing method of doxygen comments in the
driver code to be unified as follows:

```c
* @defgroup group_XXX XXX
* @brief xxxxxx
* @InGroup group_device_driver
```

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
In line with the layout of the source code, the
Device-Driver submodule should belong to components.

The doxygen Module part has been adjusted. This commit
modifies the markdown document part and moves the
device-driver pages under to components.

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
Copy link

📌 Code Review Assignment

🏷️ Tag: documentation

Path: documentation
Reviewers: @unicornx

Changed Files (Click to expand)
  • documentation/0.doxygen/2.components.h
  • documentation/6.components/INDEX.md
  • documentation/6.components/device-driver/INDEX.md
  • documentation/6.components/device-driver/adc/adc.md
  • documentation/6.components/device-driver/adc/figures/adc-p.png
  • documentation/6.components/device-driver/audio/audio.md
  • documentation/6.components/device-driver/framework/device.md
  • documentation/6.components/device-driver/framework/figures/block-dev.png
  • documentation/6.components/device-driver/framework/figures/io-call.png
  • documentation/6.components/device-driver/framework/figures/io-dev.png
  • documentation/6.components/device-driver/framework/figures/io-fun-call.png
  • documentation/6.components/device-driver/framework/figures/io-parent.png
  • documentation/6.components/device-driver/framework/figures/wtd-uml.png
  • documentation/6.components/device-driver/hwtimer/hwtimer.md
  • documentation/6.components/device-driver/i2c/figures/i2c1.png

📊 Current Review Status (Last Updated: 2025-05-29 02:26 UTC)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@unicornx unicornx requested a review from Rbb666 May 29, 2025 03:01
@Rbb666 Rbb666 merged commit 52acf7a into RT-Thread:master May 29, 2025
60 checks passed
@unicornx unicornx deleted the dev-doxygen-driver-fw branch June 19, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants