Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bsp][nxp][i2c]:fix nxp i2c addr #10037

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[bsp][nxp][i2c]:fix nxp i2c addr #10037

wants to merge 1 commit into from

Conversation

CYFS3
Copy link
Contributor

@CYFS3 CYFS3 commented Feb 25, 2025

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

PixPin_2025-02-25_17-32-37
i2c的地址为7位

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@CYFS3 CYFS3 requested a review from Rbb666 as a code owner February 25, 2025 09:33
@github-actions github-actions bot added BSP: NXP Code related with NXP BSP labels Feb 25, 2025
Rbb666
Rbb666 reviewed Feb 26, 2025
View reviewed changes
bsp/nxp/mcx/mcxa/Libraries/drivers/drv_i2c.c
@@ -67,7 +67,7 @@ static rt_ssize_t lpc_i2c_xfer(struct rt_i2c_bus_device *bus, struct rt_i2c_msg

if (msg->flags & RT_I2C_RD)
{
xfer.slaveAddress = msg->addr;
xfer.slaveAddress = msg->addr >> 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rt-thread/bsp/nxp/mcx/mcxn/Libraries/MCXN947/MCXN947/drivers/fsl_lpi2c.c

Line 956 in c3cfe6a

(uint16_t)((uint16_t)((uint16_t)transfer->slaveAddress << 1U) | (uint16_t)direction);
我看库里面是不是做了处理了？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rt-thread/bsp/nxp/mcx/mcxn/Libraries/MCXN947/MCXN947/drivers/fsl_lpi2c.c

Line 956 in c3cfe6a

(uint16_t)((uint16_t)((uint16_t)transfer->slaveAddress << 1U) | (uint16_t)direction);

我看库里面是不是做了处理了？

(addr>>1)<<1=addr

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那其他的mcx的drv_i2c是不是也改一下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那其他的mcx的drv_i2c是不是也改一下

好像不止mcx系统是七bit地址，我看lpc系列好像也是，不知道是不是nxp的库i2c的地址都是七bit的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rbb666 Rbb666 Rbb666 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
BSP: NXP Code related with NXP BSP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CYFS3 @Rbb666