feat(desktop): hide separator when availableActions is empty

[kovsu]

Before:

After:

[follow-reviewer-bot]

Thank you for your contribution. We will review it promptly.

[vercel]

@kovsu is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

[follow-reviewer-bot]

Suggested PR Title:

refactor: improve command filtering in MoreActions component

Change Summary:
Refactor MoreActions component to filter commands for availability and modify rendering logic based on action configurations, improving the component's responsiveness to command statuses.

Code Review:

Code Review: Change Requests

File: apps/desktop/src/renderer/src/modules/entry-content/actions/more-actions.tsx

1. Line 14: getCommand is used without proper validation for potential errors or null values returned by the function. Ensure getCommand(item.id) gracefully handles cases where the command is not found. If such a case is unlikely or already addressed in the implementation of getCommand, consider adding a comment to clarify.

2. Lines 17-20 (availableActions filtering):

   • The filter chaining creates potential redundancy. While the logic is correct, optimizing this to use a single filter callback may improve readability and performance. Example:

     filter((item) => item.id !== COMMAND_ID.settings.customizeToolbar && getCommand(item.id))

   • Requesting a change to refactor these chained filter calls into a single condition.

3. Lines 25-28 (extraAction filtering):

   • Similar to the availableActions filtering logic, refactor the chained filter calls into a single condition for cleaner and potentially more performant code:

     filter((item) => item.id === COMMAND_ID.settings.customizeToolbar && getCommand(item.id))

4. Line 36: The condition if (availableActions.length === 0 && extraAction.length === 0) introduces additional complexity by combining two independent filters. Consider simplifying it by maintaining separate conditions for availableActions and extraAction to maintain readability.

5. Line 50: The addition of the conditional rendering for <DropdownMenuSeparator /> with availableActions.length > 0 makes sense. However, if more separator logic is added in the future, this might become tedious to maintain. It's worth considering encapsulating this logic in a small helper function for improved clarity and better scalability as separator-related conditions grow.

---

Recommended Actions

• Refactor filter chains into single conditions where possible.
• Add validation or comments for getCommand(item.id) usage.
• Simplify conditional logic in if (availableActions.length === 0 && extraAction.length === 0) for better readability.

Let me know if you need help implementing these changes!

[follow-reviewer-bot]

Thank you @kovsu for your contribution! 🎉

Your pull request has been merged and we really appreciate your help in making this project better. We hope to see more contributions from you in the future! 💪