Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): implement onboarding screen #3029

Merged
merged 11 commits into from
Mar 13, 2025
Merged

feat(mobile): implement onboarding screen #3029

merged 11 commits into from
Mar 13, 2025

Conversation

lawvs
Copy link
Member

@lawvs lawvs commented Mar 11, 2025

Resolve FOL-1660

Introduce a new onboarding flow with multiple steps, including a welcome screen, preferences selection, and interests selection.

Screenshot 2025-03-12 at 03 35 37

Screenshot 2025-03-12 at 03 36 03

Screenshot 2025-03-12 at 03 36 37

Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 9:03am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
follow-external-ssr ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2025 9:03am

@follow-reviewer-bot
Copy link

Suggested PR Title:

feat(onboarding): implement onboarding steps and reading behavior

Change Summary:
Added onboarding steps for user preferences and reading behavior, enhancing the user experience with tailored settings. This includes new screens and hooks for managing reading preferences and introducing a complete onboarding flow.

Code Review:

Code Review: Change Requests

apps/mobile/src/modules/onboarding/hooks/use-reading-behavior.ts

  1. Line 10-28:
    • Missing default case in the switch statement of the updateSettings function. If an unhandled value of ReadingBehavior is passed, the function will fail silently. Add a default case to handle unexpected behavior values, such as logging an error or providing a fallback.

apps/mobile/src/modules/onboarding/step-preferences.tsx

  1. Line 13:
    • There is an unused import of PropsWithChildren in this file. Remove the unused import to keep the code clean.

apps/mobile/src/modules/onboarding/step-interests.tsx

No issues found in this file.

apps/mobile/src/modules/onboarding/welcome.tsx

No issues found in this file.

apps/mobile/src/screens/(modal)/select-reading-mode.tsx

No issues found in this file.

apps/mobile/src/screens/_layout.tsx

  1. Line 81-91:
    • The presentation: "transparentModal" for the onboarding screen may cause issues on devices or platforms where transparent modals are not well-supported. Verify cross-platform compatibility for transparent modals and include a fallback if issues are encountered.

apps/mobile/src/screens/onboarding.tsx

  1. Line 13:
    • The handleNext function does not adequately guard against scenarios where currentStep exceeds totalSteps. Consider validating currentStep with a Math.min operation or an additional conditional clause to prevent unexpected behavior if the function is called multiple times improperly.

Please address the issues highlighted above to ensure robustness, maintainability, and compatibility of the code.

Copy link

linear bot commented Mar 13, 2025

FOL-1660 New user guide

@lawvs lawvs force-pushed the feat/onboarding branch from a8bdef9 to 9533cee Compare March 13, 2025 09:01
@lawvs lawvs merged commit 2d92a4f into dev Mar 13, 2025
11 checks passed
@lawvs lawvs deleted the feat/onboarding branch March 13, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant