Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(desktop): update shortcut for copying entry link #3020

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

kovsu
Copy link
Contributor

@kovsu kovsu commented Mar 11, 2025

Description

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Screenshots (if UI change)

CleanShot.2025-03-11.at.09.34.55.mp4

Demo Video (if new feature)

Linked Issues

Close: #3005

Additional context

Changelog

  • I have updated the changelog/next.md with my changes.

@follow-reviewer-bot
Copy link

Thank you for your contribution. We will review it promptly.

Copy link

vercel bot commented Mar 11, 2025

@kovsu is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

@follow-reviewer-bot
Copy link

Suggested PR Title:

fix: update shortcut for copying entry link

Change Summary:
Updated keyboard shortcut for copying entry link instead of title.

Code Review:

  • File: apps/desktop/src/renderer/src/hooks/biz/useEntryActions.tsx
  • Line: 147
    • Issue: The shortcut property has been modified to reference shortcuts.entry.copyLink.key instead of shortcuts.entry.copyTitle.key. There is insufficient context in the PR to validate whether this change is intentional or correct. This could lead to functionality mismatch if the intended shortcut behavior was originally tied to copyTitle.
    • Required Change: Ensure that the new shortcut value (shortcuts.entry.copyLink.key) aligns with the intended behavior for the COMMAND_ID.entry.copyLink action. If this is not intentional, revert it to shortcuts.entry.copyTitle.key. Additionally, verify associated test cases (if any) to ensure behavioral consistency.

If this change is intentional, it would be helpful to include documentation or PR description details explaining the purpose of this adjustment for future reference.

@kovsu
Copy link
Contributor Author

kovsu commented Mar 11, 2025

Should I add copy title into here?

@Innei Innei merged commit 292d5c5 into RSSNext:dev Mar 12, 2025
3 of 6 checks passed
@follow-reviewer-bot
Copy link

Thank you @kovsu for your contribution! 🎉

Your pull request has been merged and we really appreciate your help in making this project better. We hope to see more contributions from you in the future! 💪

@kovsu kovsu deleted the fix-#3005 branch March 12, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy link shortcut key not working
3 participants