Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update app activation event handling in Electron #2838

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

songhanlin
Copy link
Contributor

Description

Fixed a bug where the Follow window could not be reopened by clicking the Dock icon after closing it with CMD+W. This improves the macOS user experience by ensuring standard window management behavior.

PR Type

  • Bugfix
  • Feature
  • Hotfix
  • Other (please describe):

Additional context

This fix restores the expected macOS window management behavior where clicking the Dock icon should reopen a closed window.

Changelog

  • I have updated the changelog/next.md with my changes.

@follow-reviewer-bot
Copy link

Thank you for your contribution. We will review it promptly.

Copy link

vercel bot commented Feb 21, 2025

@songhanlin is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

@follow-reviewer-bot
Copy link

Suggested PR Title:

refactor: update app activation event handling in Electron

Change Summary:
Refactored event handling for app activation in Electron.

Code Review:
No change requests necessary.

@songhanlin songhanlin changed the title chore: fix bug where clicking the Dock icon cannot reopen the window … refactor: update app activation event handling in Electron Feb 21, 2025
Copy link
Member

@Innei Innei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Innei Innei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Innei Innei merged commit ac1332e into RSSNext:dev Feb 21, 2025
1 of 3 checks passed
@follow-reviewer-bot
Copy link

Thank you @songhanlin for your contribution! 🎉

Your pull request has been merged and we really appreciate your help in making this project better. We hope to see more contributions from you in the future! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants