Skip to content

close issue 1 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2019
Merged

close issue 1 #2

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdbb628
close issue 1
codygreen Aug 20, 2019
dcab32c
updated readme with terraform version
codygreen Aug 21, 2019
fc8984b
Update terraform/lambda.tf
codygreen Aug 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Lambda function to handle CodePipeline CloudWatch events and send a notification
![Started](docs/sample-notification-succeeded.png)

### Deployment
Requires Terraform to be installed.
Requires Terraform 0.12+ to be installed.

1. Change permissions of deployment bash script `chmod +x deploy.sh`
2. Run `./deploy.sh` which will prompt you for the following variables:
Expand Down
12 changes: 6 additions & 6 deletions terraform/lambda.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ resource "aws_lambda_function" "lambda" {
function_name = "codepipeline-teams-notifications"
role = "${aws_iam_role.lambda.arn}"
handler = "index.handler"
source_code_hash = "${base64sha256(file("../lambda.zip"))}"
source_code_hash = "${base64sha256("../lambda.zip")}"
runtime = "nodejs8.10"
timeout = 20

Expand All @@ -15,9 +15,9 @@ resource "aws_lambda_function" "lambda" {
}

resource "aws_lambda_permission" "cloudwatch_execution" {
statement_id = "AllowExecutionFromCloudWatch"
action = "lambda:InvokeFunction"
function_name = "${aws_lambda_function.lambda.function_name}"
principal = "events.amazonaws.com"
source_arn = "${aws_cloudwatch_event_rule.codepipeline_event.arn}"
statement_id = "AllowExecutionFromCloudWatch"
action = "lambda:InvokeFunction"
function_name = "${aws_lambda_function.lambda.function_name}"
principal = "events.amazonaws.com"
source_arn = "${aws_cloudwatch_event_rule.codepipeline_event.arn}"
}