Proof of concept for namespace deserialization

[estk]

Hi there, I'm hoping to get some feedback with respect to the issue: #92.

Also, I apologize for the noise due to rustfmt.

[punkstarman]

Isn't rustfmt producing some strange line breaks?

XmlEvent::StartElement { ref name, .. } => seed.deserialize(

becoming

XmlEvent::StartElement { ref name, .. } => seed
  .deserialize(

I would rather

XmlEvent::StartElement { ref name, .. } =>
  seed.deserialize(

[estk]

@punkstarman I really dont know about the style stuff, I feel like it should be as is specified in the rustfmt.toml file. I have my editor set to use that. Anyway, I'm pretty happy with the api, if youre still not interested in this feature I'll just maintain my fork.

[reneherrero]

wondering if a decision has been made regarding support for namespaces?

[punkstarman]

@reneherrero, I plan to add support based on a spike I did on https://github.com/punkstarman/serde-xml. Time is lacking atm

[reneherrero]

@punkstarman No worries, I understand.

To be honest, I think you have an uphill battle. I have a feeling you're going to face the "lowest common denominator" problem due to the dependency on serde. I tried Yaserde but that didn't let me cross the finish line either... Fact of the matter is that XML can be quite elaborate and supporting every feature will likely require a dedicated library. Just my two cents.

I switched to libxml and that got me where I needed to get (also supports XSLT), granted adds an C lib dependency, quite a bit more verbose and nowhere as elegant.

[punkstarman]

@reneherrero, namespace support was a crunchy problem, but I managed to find a way of supporting it by changing the API ever so slightly.

[reneherrero]

@punkstarman I have been wrong before... you're one brave dude :)

Let me know when you have something that is testable. Would like to try it with the XML files like these:

• https://raw.githubusercontent.com/iho-ohi/S-101-Test-Datasets/main/S-164/v4/BaseTest/BaseTest/1012C002C3NEWCC/CATALOG.XML
• https://raw.githubusercontent.com/iho-ohi/S-101_Portrayal-Catalogue/main/FeatureCatalog.xml

[oneslash]

I want to bring up a discussion on this again. Is it in progress, or can I pick it up?

[wt]

I'm curious. Is anything happening in this space?

[Cabbache]

I've forked it to include the namespace in the attribute name as a workaround for me: #216

example:

#[serde(rename = "namespace:attrname")]
namespace_attrname: String,