Switch from write to xml-rs #40
Conversation
|
We should merge it behind #36 |
| Self { writer: writer } | ||
| } | ||
|
|
||
| #[cfg(test)] |
There was a problem hiding this comment.
Would it be better to rename this new_without_xml_declaration() or something similar? That way we can expose it to the user (if we want to) and it doesn't sound like we're making a special case simply for testing.
| write!(self.parent.writer, "<")?; | ||
| key.serialize(&mut *self.parent)?; | ||
| write!(self.parent.writer, ">")?; | ||
| let key = key.serialize(&mut MapKeySerializer)?; |
There was a problem hiding this comment.
I made a very similar thing in #36 to detect whether something would be "wrapped" when serialized and mentioned we can use it to resolve this todo. I think it's a bit more general than your MapKeySerializer, so when #36 lands should we try to adapt this bit of code to use that?
To make WrapSafeDetector more useful, it could probably return an enum which represents roughly which type of thing something is (e.g. Kind::String, Kind::Complex, Kind::Numeric) with is_wrapped() being a helper method.
|
Hi. What's the status of this? |
3 participants
Fixes #39