Skip to content

Conversation

@Michael-F-Bryan
Copy link
Contributor

This adds support for serializing newtype structs.

@oli-obk
Copy link
Contributor

oli-obk commented Aug 22, 2017

This looks good to me. Can you add a few more tests with interesting newtype elements?

  • Option
  • another newtype
  • Vec
  • BTreeMap

Newtypes in xml have always been somewhat troublesome when combined with other types.

@Michael-F-Bryan
Copy link
Contributor Author

Michael-F-Bryan commented Aug 22, 2017

I don't think I can do a test for Vec and BTreeMap yet because sequences and maps aren't yet supported (I've made a PR for the sequences bit - #36). I'll try to add tests for other things though.

@Michael-F-Bryan
Copy link
Contributor Author

I thing I'm going to merge this into #36 because they're essentially two heads of the same coin.

@Michael-F-Bryan Michael-F-Bryan deleted the newtype branch August 24, 2017 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants