Support fish shell #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses crash when no name is given to a function, and the cursor position gets lost.
Add another function definition matching functions with options. This stops incorrect matching, causing errors when finding the cursor.
RRethy
reviewed
Jun 28, 2023
|
|
||
| test "fish, global function with options", <<~END | ||
| -function foo --on-signal WINCH █ | ||
| +function foo --on-signal WINCH |
There was a problem hiding this comment.
Suggested change
| +function foo --on-signal WINCH | |
| +function foo --on-signal WINCH |
There was a problem hiding this comment.
Ooops I'll fix that.
RRethy
requested changes
Jun 28, 2023
|
I think I tried that and had problems. Presumably my ruby is dodgy or neovim config is different or something. Would be awesome to set up CI with actions. |
|
Fix is in anyway :) Thanks for getting to it so fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - thanks for the great library, such a helpful example of the power of treesitter.
I've implemented endwise queries for the fish shell language.
I also added some test cases, but I haven't actually been able to configure my system correctly in order to run them. I think they each passed under manual testing...
Let me know if you need anything else from my end.