createAsset improvements in error checking and capabilities.#5918
Closed
Jmr3366 wants to merge 3 commits intoRPTools:developfrom
Closed
createAsset improvements in error checking and capabilities.#5918Jmr3366 wants to merge 3 commits intoRPTools:developfrom
Jmr3366 wants to merge 3 commits intoRPTools:developfrom
Conversation
cwisniew
requested changes
Jan 19, 2026
Member
There was a problem hiding this comment.
Instead of adding the coding to try determine what type of asset is in the base64 string, convert the base64 string to a byte array and use
Asset.createAssetDetectType(String name, byte[] data) This way the function will support any image asset MT supports now or in the future without having to constantly update/fix this function
Then you can use asset.getType() to determine if it is an image or text, and check if it is a URI if it is text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
fixes #5917
Description of the Change
createAsset was using strings to check for image format and could fail. This is now using bytes.
You could not take a base64 encoded PNG string (but base64 encoded webp would work??) and use it with createAsset.
Possible Drawbacks
There should be none.
This change is