Skip to content

Generate walls from UVTT line-of-sight data - #5406

Merged
cwisniew merged 3 commits into
RPTools:developfrom
kwvanderlinde:feature/5182-uvtt-import-line-of-sight-as-walls
May 6, 2025
Merged

Generate walls from UVTT line-of-sight data#5406
cwisniew merged 3 commits into
RPTools:developfrom
kwvanderlinde:feature/5182-uvtt-import-line-of-sight-as-walls

Conversation

@kwvanderlinde

@kwvanderlinde kwvanderlinde commented May 6, 2025

Copy link
Copy Markdown
Collaborator

Identify the Bug or Feature request

Resolves #5182

Description of the Change

When importing a UVTT file, the user now has a choice of whether to generate VBL+MBL as always, or to use the newer walls. By default, the user is prompted for a choice each time, but this choice can optionally be remembered for future imports. Alternatively, the choice can be set in the Preferences dialog.

When generating walls, open portals are represented as walls, albeit walls the don't block movement, sights, lights, or auras. This differs from the VBL+MBL import where open portals result in nothing, but is consistent in terms of not blocking anything. Since a wall is created, the user can easily modify the blocking properties of any portals to their liking after the import is completed, in case this default behaviour does not suffice.

Possible Drawbacks

Users may be confused at first with the extra prompt.

Documentation Notes

Either walls or *BL can be used to represent the line of sight data from a Universal VTT file. When importing a UVTT file, you will be asked which one you want to use:
image

If you don't want to be asked every time, select the "Remember my choice" option:
image

Alternatively, you can set your preferred option via Preferences:
image

Release Notes

  • Added the option for walls to be generated during UVTT import instead of VBL+MBL

This change is Reviewable

@github-actions github-actions Bot added the feature Adding functionality that adds value label May 6, 2025
@kwvanderlinde kwvanderlinde moved this from Todo to Awaiting-Review in MapTool 1.18 May 6, 2025
This avoids unnecessary casework regarding transforms and nullability, so that the essence is clearer for when walls are
added.
Options are to import as masks, import as walls, or to prompt the user on each import for what they want. The default is
to prompt.
If the user requests walls (either via preference or prompt), then walls are generated to represent the UVTT line of
sight information. No VBL or MBL is generated in this case. If the user instead requests masks, then the legacy VBL+MBL
is generated.

If the user cancels the prompt for which type to use, the entire import is cancelled.
@kwvanderlinde
kwvanderlinde force-pushed the feature/5182-uvtt-import-line-of-sight-as-walls branch from cb097ff to 4fff3d2 Compare May 6, 2025 06:47
@FullBleed

Copy link
Copy Markdown

Do you foresee there being more uvtt type settings in the future? If so, it might be good to give uvtt settings their own tab so they can be safely ignored--or easily found--as needed. Other instructions/expectations for how MT handles uvtt files could also be included in such a tab.

@cwisniew

cwisniew commented May 6, 2025

Copy link
Copy Markdown
Member

Do you foresee there being more uvtt type settings in the future? If so, it might be good to give uvtt settings their own tab so they can be safely ignored--or easily found--as needed. Other instructions/expectations for how MT handles uvtt files could also be included in such a tab.

UVTT is limited to what it can contain, I can't see many more options other than create lights in the near future, it would be more likely that in the future there would be other import formats -- not that this is likely either -- and it could be grouped with them in another tab if it ever happens.

@github-project-automation github-project-automation Bot moved this from Awaiting-Review to To-Be-Merged in MapTool 1.18 May 6, 2025
@cwisniew
cwisniew added this pull request to the merge queue May 6, 2025
Merged via the queue into RPTools:develop with commit ba4ee9e May 6, 2025
@github-project-automation github-project-automation Bot moved this from To-Be-Merged to Merged in MapTool 1.18 May 6, 2025
@kwvanderlinde
kwvanderlinde deleted the feature/5182-uvtt-import-line-of-sight-as-walls branch May 6, 2025 15:30
@Baaaaaz

Baaaaaz commented May 7, 2025

Copy link
Copy Markdown
Contributor

@kwvanderlinde Typo in the dialog title? Should read "Universal" not "Universla".
https://github.com/search?q=repo%3ARPTools%2Fmaptool%20universla&type=code

@kwvanderlinde kwvanderlinde mentioned this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Adding functionality that adds value

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

[Feature]: Add option to generate walls instead of masks when importing UVTT

4 participants