Consolidated getFootprints to aid translation. - #5366
Merged
Conversation
arguments to the i18n.getText. Moved getFootprints out of individual Grid classes into Grid. Consolidated error messages into one string with the grid type passed as an argument.
kwvanderlinde
requested changes
Apr 20, 2025
kwvanderlinde
approved these changes
Apr 21, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
fixes #5365
specifically addressing this comment
Description of the Change
Brought similar error messages together under one string with the grid type as an argument.
As the message is used with showError, I added overloads for showError and generateMessage to accept additional parameters.
Since I was consolidating code, I moved all getFootprints from the various grid classes and put them under Grid.
Possible Drawbacks
I may break things unwittingly.
Documentation Notes
N/A
Release Notes
N/A
This change is