Hide statsheet overlay when no statsheet visible, and overlay panel when no overlay is visible - #5264
Merged
cwisniew merged 2 commits intoFeb 15, 2025
Conversation
github-actions
Bot
added
feature
cwisniew
approved these changes
Feb 15, 2025
kwvanderlinde
deleted the
refactor/5238-hide-statsheet-overlay-and-overlay-panel
branch
February 15, 2025 19:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Resolves #5238
Description of the Change
This changes stat sheets specifically so the internal overlay is hidden when no stat sheets are displayed. Existing behaviour is that the overlay remains visible but has no content.
Overlays in general are changed to hide themselves if all overlays are hidden. It will show itself again when any overlay becomes visible. This is handled through a new
OverlayVisibilityChangedevent. Newly shown overlays also cause the panel to be shown, e.g., in response to anoverlay()roll.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is