Move heart beat task into MapToolClient - #5263
Merged
cwisniew merged 1 commit intoFeb 15, 2025
Merged
Conversation
The new task is scheduled with a `ScheduledExecutorService` so we don't have to manage our own thread or run a busy wait loop.
github-actions
Bot
added
the
refactor
cwisniew
approved these changes
Feb 15, 2025
kwvanderlinde
deleted the
refactor/5262-better-manage-ServerHeartBeatThread
branch
May 15, 2025 03:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Closes #5262
Description of the Change
The
ServerHeartBeatThreadthread is removed in favour of a task (Runnable) scheduled repeatedly with an executor. This task is only scheduled whenMapToolClientis started, and it is canceled whenMapToolClientis stopped. So each connection will get its own heart beat unlike before.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is