Skip to content

MTScript Drawing functions - #5158

Merged
cwisniew merged 45 commits into
RPTools:developfrom
bubblobill:DrawingFunctions
Feb 6, 2025
Merged

MTScript Drawing functions #5158
cwisniew merged 45 commits into
RPTools:developfrom
bubblobill:DrawingFunctions

Conversation

@bubblobill

@bubblobill bubblobill commented Jan 31, 2025

Copy link
Copy Markdown
Collaborator

Identify the Bug or Feature request

resolves #1410 #5154
allows principal functionality requested in #2743
creates base for implementing #3189
contributes towards implementing #4867
will make implementing #4584 easier

Description of the Change

A set of functions that allows the creation and manipulation of Java Shapes.
Shapes are stored in a cache with a string or GUID key.
Shapes can subsequently be drawn to a zone and manipulated with existing drawing functions.

Possible Drawbacks

Hardly intuitive, but the shapes are (for the most part) just direct implementations of Java Shapes.
Doesn't get existing drawing shapes.

Documentation Notes

Added Procedural creation of Drawings.

Release Notes

Added Procedural creation of Drawings.


This change is Reviewable

…required.

Function to confirm existence of required keys in JSON Object.
Function to return JSON Object with keys converted to lower case.
"shape.areaAdd",
        "shape.areaSubtract",
        "shape.clearAll",
        "shape.combinePaths",
        "shape.create",
        "shape.delete",
        "shape.draw",
        "shape.getProperties",
        "shape.list",
        "shape.transform"
ArcDto,CubicCurveDto,LineDto,PolygonShapeDto,QuadCurveDto,RoundRectangleDto,Rectangle2DDto
@github-actions github-actions Bot added the feature Adding functionality that adds value label Jan 31, 2025
@bubblobill

Copy link
Copy Markdown
Collaborator Author

@cwisniew still no delimiter field :P

@bubblobill bubblobill self-assigned this Feb 2, 2025
@bubblobill

Copy link
Copy Markdown
Collaborator Author

Complete with delimiter options

@bubblobill
bubblobill marked this pull request as draft February 3, 2025 06:47
@bubblobill
bubblobill marked this pull request as ready for review February 3, 2025 08:32
@cwisniew
cwisniew added this pull request to the merge queue Feb 6, 2025
Merged via the queue into RPTools:develop with commit 8a4c429 Feb 6, 2025
@kwvanderlinde

Copy link
Copy Markdown
Collaborator

@bubblobill Can you add documentation for how to use each of the new functions?

@kwvanderlinde kwvanderlinde linked an issue Feb 13, 2025 that may be closed by this pull request
@bubblobill

bubblobill commented Feb 13, 2025

Copy link
Copy Markdown
Collaborator Author

@kwvanderlinde
https://discord.com/channels/296230822262865920/626585709016252426/1335484862374875229

github-merge-queue Bot pushed a commit that referenced this pull request May 13, 2025
Improvements and fixes for Shape functions #5154 / PR #5158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Adding functionality that adds value

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

[Feature]: Drawing functions for creating and modifying Feature: Edit Properties of a drawing in the Draw Explorer

3 participants