Go back to calling MapTool.setCampaign() - #4774
Merged
cwisniew merged 1 commit intoMay 8, 2024
Merged
Conversation
For now, the global `MapTool.setCampaign()` still does a fair bit of work outside of `MapToolClient`, so it was not correct to have removed it the call to it in `ClientMessaageHandlder`. On the other hand, the call to `MapTool.getPlayerList()` is not necessary.
cwisniew
approved these changes
May 8, 2024
kwvanderlinde
deleted the
fixup/pr-4771-bad-state-when-connected-now-for-some-reason
branch
May 13, 2024 23:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes PR #4771
Description of the Change
As part of my cleanup in the previous PR, I switched
ClientMessageHandlerfrom callingMapTool.setCampaign()to directly callingMapToolClient.setCampaign(). This is a mistake since - for now anyways -MapTool.setCampaign()still does a few important things that are separate fromMapToolClient. This new PR addresses that.Possible Drawbacks
Only upsides 🙂
Documentation Notes
N/A
Release Notes
N/A
This change is