Correctly centre map labels and fix colors for some old labels that had wrong coloring. - #4716
Merged
Conversation
cwisniew
enabled auto-merge
March 15, 2024 00:49
thelsing
approved these changes
Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4706
Description of the Change
Labels are not being centred correctly, so I have updated the rendering to fix their locations.
Possible Drawbacks
This means labels created with RC1 will be in the wrong place with the next release.
Since the sizes of labels are different there will not be a pixel perfect match of locations for the labels but they will be centred in same location and their bounds will be very close to before 1.15.
Documentation Notes
Fixes rendering locations of labels
Pre 1.15
Fixes
Release Notes
This change is