Skip to content

Allow build to succeed even with stray sentry.properties file - #4423

Merged
cwisniew merged 1 commit into
RPTools:developfrom
kwvanderlinde:refactor/4399-make-build-resilient-in-presence-of-stray-sentry-config
Nov 18, 2023
Merged

Allow build to succeed even with stray sentry.properties file#4423
cwisniew merged 1 commit into
RPTools:developfrom
kwvanderlinde:refactor/4399-make-build-resilient-in-presence-of-stray-sentry-config

Conversation

@kwvanderlinde

@kwvanderlinde kwvanderlinde commented Nov 17, 2023

Copy link
Copy Markdown
Collaborator

Identify the Bug or Feature request

Improves PR #4401 for #4399

Description of the Change

When evaluating older commits, the lingering sentry.properties file makes the build fail due to conflicts with the new directly written version. This makes testing and bisecting more tedious than it needs to be. This PR introduces a change to allow the file to exist, but to ultimately have no effect other than this warning being generated:

Encountered duplicate path "sentry.properties" during copy operation configured with DuplicatesStrategy.WARN

Possible Drawbacks

None

Documentation Notes

N/A

Release Notes

N/A


This change is Reviewable

If the file is present in the `src/` directory (as when switching from an older branch), gradle will show this warning
but otherwise succeed and use the correct updated version of the file:
> Encountered duplicate path "sentry.properties" during copy operation configured with DuplicatesStrategy.WARN
@cwisniew
cwisniew added this pull request to the merge queue Nov 18, 2023
Merged via the queue into RPTools:develop with commit 7c00b95 Nov 18, 2023
@cwisniew cwisniew added the bug label Nov 18, 2023
@kwvanderlinde
kwvanderlinde deleted the refactor/4399-make-build-resilient-in-presence-of-stray-sentry-config branch November 18, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactoring]: Stop writing build artifacts to the source directory

2 participants