Skip to content

Add game invite handling to friends overlay #18417 - #19108

Merged
Megamouse merged 4 commits into
RPCS3:masterfrom
primetime43:master
Jul 29, 2026
Merged

Add game invite handling to friends overlay #18417#19108
Megamouse merged 4 commits into
RPCS3:masterfrom
primetime43:master

Conversation

@primetime43

Copy link
Copy Markdown
Contributor

Split the friends dialog invite flow into friend requests and game invitations, add a dedicated game invite page, and wire accept/reject actions with the proper prompts. Accepting now routes through a new np_handler::select_invitation helper that validates invite messages, notifies the game, and marks invites as used. Also added locking around selected-message state in np_handler to make selection access thread-safe, plus new localized strings for the added UI text.

Split the friends dialog invite flow into friend requests and game invitations, add a dedicated game invite page, and wire accept/reject actions with the proper prompts. Accepting now routes through a new `np_handler::select_invitation` helper that validates invite messages, notifies the game, and marks invites as used. Also added locking around selected-message state in `np_handler` to make selection access thread-safe, plus new localized strings for the added UI text.
Fix style issues to follow RPCS3 guide
Comment thread rpcs3/Emu/NP/np_handler.h Outdated
Comment thread rpcs3/Emu/NP/np_handler.cpp
Comment thread rpcs3/Emu/RSX/Overlays/FriendsList/overlay_friends_list_dialog.cpp Outdated
Track RPCN invite messages in a dedicated in-memory list, append new invites from the callback, and remove invites immediately after accept/dismiss so stale entries are not reprocessed on reload. Also make `np_handler::select_invitation` return `bool` consistently and clear selected invitation data if the system notification fails.

@RipleyTom RipleyTom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread rpcs3/Emu/RSX/Overlays/FriendsList/overlay_friends_list_dialog.cpp Outdated
Move `m_list_dirty = true` inside the successful insert path in `add_game_invite`, so the friends invite overlay only refreshes when a new invite is actually added instead of on duplicate/no-op updates.
@Megamouse
Megamouse merged commit 8846521 into RPCS3:master Jul 29, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants