Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPU: Improve SPURS Task limit algorithm #16129

Merged
merged 1 commit into from
Sep 27, 2024
Merged

SPU: Improve SPURS Task limit algorithm #16129

merged 1 commit into from
Sep 27, 2024

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Sep 26, 2024 •
edited
Loading

Test performance regressions with #16128 please.
Also fixes #16127

@elad335 elad335 mentioned this pull request Sep 26, 2024
Closed
@Margen67
Copy link
Contributor

penalty*

@JimScript
Copy link

JimScript commented Sep 26, 2024 •
edited
Loading

Well it's somewhat of an improvement over the regression in lighter areas, but it's still not as good as it was before, the spot I go to still stutters:
20240926114329_1

@elad335
Copy link
Contributor Author

elad335 commented Sep 26, 2024

@JimScript I need numbers, enable Performance Overlay and take the screenshots with it.

@JimScript
Copy link

Right, sorry, here is a more detailed sequence of images:
20240926131559_1
20240926131605_1
20240926131625_1
20240926131632_1

@elad335 elad335 force-pushed the elad335-patch-1 branch 2 times, most recently from b8ef9d0 to 7730d2b Compare September 27, 2024 08:15
@elad335 elad335 mentioned this pull request Sep 27, 2024
Closed
@elad335 elad335 added CPU Bugfix Performance Performance related, not directly an optimization. labels Sep 27, 2024
@elad335
Copy link
Contributor Author

elad335 commented Sep 27, 2024

@JimScript Retest.

@elad335
Copy link
Contributor Author

elad335 commented Sep 27, 2024

This also contains a hotfix so I merge it, but performance testing is still needed!

@elad335 elad335 changed the title [TESTERS NEEDED] SPU: Double SPURS Task delay panelty in SPURS Threads limits SPU: Improve SPURS Task limit algorithm Sep 27, 2024
@elad335 elad335 merged commit 10dece1 into master Sep 27, 2024
7 checks passed
@shinra-electric
Copy link
Contributor

shinra-electric commented Sep 27, 2024 •
edited
Loading

Not related to performance, but Demon's Souls used to require the max spurs thread set to 3 (according to the wiki).

Now it doesn't boot with it set to 3 (black screen), but it works fine set to unlimited.

Other games that require this setting to be changed should probably be tested and the wiki updated...

(Tested on macOS Arm build, M1 pro)

@elad335 elad335 deleted the elad335-patch-1 branch September 27, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bugfix CPU Performance Performance related, not directly an optimization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Regression] Some Insomniac games crash to desktop after #16124
4 participants
@elad335 @Margen67 @JimScript @shinra-electric