Visual Studio: Fix debug builds #15300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
added
OS: Windows
Build and CI
Megamouse
force-pushed
the
warnings
branch
3 times, most recently
from
f70463d to
2be4700
Compare
This fixes heap assertions caused by mixing static builds and dynamic Qt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why we get the heap assert with MulitThreadedDebug is that we load Qt as DLL, so there is a different heap allocator for Qt and the rest of the project. This means that whenever we use a local Qt object that allocates on the heap (e.g. QString), we got the assert.
This implies that we should also consider moving to MulitThreadedDLL for release, which creates rpcs3.lib, or alternatively build and link Qt statically.
Fixes #15281