Ensure HDD1 is never damaged or corrupted due to unexpected RPCS3/game close #15036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
force-pushed
the
hdd1
branch
2 times, most recently
from
c398a84 to
0ad00d1
Compare
Megamouse
reviewed
Jan 11, 2024
elad335
force-pushed
the
hdd1
branch
3 times, most recently
from
8da48dd to
6f25d03
Compare
Megamouse
reviewed
Jan 11, 2024
| @@ -141,8 +193,8 @@ error_code cellSysCacheMount(vm::ptr<CellSysCacheParam> param) | |||
|
|
|||
| std::lock_guard lock0(g_mp_sys_dev_hdd1.mutex); | |||
|
|
|||
| // Check if can reuse existing cache (won't if cache id is an empty string) | |||
| if (param->cacheId[0] && cache_id == cache.cache_id) | |||
| // Check if can reuse existing cache (won't if cache id is an empty string or cache is damaned/incomplete) | |||
There was a problem hiding this comment.
Suggested change
| // Check if can reuse existing cache (won't if cache id is an empty string or cache is damaned/incomplete) | |
| // Check if can reuse existing cache (won't if cache id is an empty string or cache is damaged/incomplete) |
rpcs3/Emu/Memory/vm_ptr.h
Outdated
| struct fmt_class_string<vm::_ptr_base<char[Size], u32>, void> : fmt_class_string<vm::_ptr_base<const char, u32>> | ||
| { | ||
| // Classify char[] as const char* | ||
| }; |
|
Just to confirm, this doesn't fix #15017 - the issue with that one seems to relate to HDD0 rather than HDD1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14958