rsx: Discard color mask writes with reserved bits #14545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
force-pushed
the
modulo
branch
2 times, most recently
from
6fdec37 to
b7d6994
Compare
|
This causes corrupted UI menus graphics on Split/Second. Before: After: |
|
Apparently this causes a huge regression to almost every game, including Demon's Souls. |
|
Retest. |
|
The graphics now renders properly. |
|
B4 After Also apparently fix the issue of my livery being full black in Nascar: Inside Line Edit1: I hope i fixed the image not loading |
|
Fixes #10530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testcase: https://github.com/elad335/myps3tests/tree/master/rsx_tests/write%20output%20mask
This testcase tests what happens on a write to ones to reserved of color mask register
It does this by iterating and ORis valid masks with a single reserved bit at a time, for completeness it also tests it with valid bit masks as well and examines buffer state.
Results: writes with reserved bits set are being ignored by RSX.
Fixes the colors in #13101.
Fixes #10530.
Fixes #10533.