Emu: Cache games.yml and only save when necessary #13716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
force-pushed
the
games_yml
branch
3 times, most recently
from
8439c9e to
b486cc9
Compare
elad335
reviewed
Apr 21, 2023
| @@ -3177,12 +3132,16 @@ void Emulator::AddGamesFromDir(const std::string& path) | |||
|
|
|||
| if (const auto error = BootGame(dir_path, "", false, true); error == game_boot_result::no_errors) | |||
| { | |||
| if (std::exchange(m_games_yml_invalidated, false)) | |||
There was a problem hiding this comment.
It's already logged in load
There was a problem hiding this comment.
Also, i would have to clear the dirty flag each time which only complicates things for no reason
elad335
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that if you had 200 games in your /games folder, you will now have at least 200 reads less during startup than before.
The reduction in write during startup won't be as amazing, since we only saved the games.yml when an entry was added (at least with the commit prior to this one).