Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skylander Portal: Trap Team Audio Transfers #13565

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

deReeperJosh
Copy link
Contributor

@deReeperJosh deReeperJosh commented Mar 20, 2023

Should fix #12887

Audio transfers are 64 bytes long (32 x 16 bit audio samples, 8khz mono), but the current code ensures the buf size is 32 only for interrupt transfers. This fix should let users play through Trap Team with the Emulated Portal, by allowing 64 byte transfers and not returning the status of the portal if it is an audio transfer.

Note that this is untested, it is simply based on the work I did within Dolphin to implement the same.

@RipleyTom
Copy link
Contributor

RipleyTom commented Mar 20, 2023

Hmm I didn't realize there were actually interrupt output towards the device.
Maybe separating the check depending on the endpoint used.
Check if (!(pipe.endpoint & 0x80)) to see if it's an output endpoint then the size check==0x40 for output endpoint only?

@deReeperJosh
Copy link
Contributor Author

Yeah that makes sense - I was able to test this in the end on my Mac and it did not fix the issue, so will just go back through and make sure everything else is working as expected before adding that check in

@deReeperJosh
Copy link
Contributor Author

Had to take some time away from this but have come back, it would actually appear that the endpoint for audio is 0x02, and everything else is 0x81. Have built and tested this locally as working - will rebase shortly :)

@deReeperJosh deReeperJosh force-pushed the trapteaminterrupts branch 3 times, most recently from 0975394 to 582c1e8 Compare April 7, 2023 22:33
@Megamouse Megamouse merged commit 86b3229 into RPCS3:master Apr 11, 2023
@deReeperJosh deReeperJosh deleted the trapteaminterrupts branch April 12, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skylanders Trap Team emulated portal problem.
3 participants