Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PINE: Fix crash on exit #13409

Merged
merged 6 commits into from
Feb 20, 2023
Merged

PINE: Fix crash on exit #13409

merged 6 commits into from
Feb 20, 2023

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Feb 17, 2023

No description provided.

@dio-gh
Copy link
Contributor

dio-gh commented Feb 19, 2023

Improves #13405:

image

Wasn't sure how to test it first, but then I came up with a reasonable method, see below.

Testing methodology (click to expand)
  • grab PR build, extract it fresh
  • launch it, enable the IPC server
  • restart it, force an update
  • before hitting ok to restart, overwrite the files with the PR build
  • hit ok to restart, and see what happens

Confirmed on the mainline builds that this is way of testing it still reproduces the issue if present, so should be fine I think.

@Megamouse
Copy link
Contributor

The more important question is whether or not the pine server still works properly

@dio-gh
Copy link
Contributor

dio-gh commented Feb 19, 2023

Good point. Checked with KAMI now and yes, it still does: both status reporting and mouse hooking appears to work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants