macOS CI: move to AArch64 VM (x64 builds) #13155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastys
force-pushed
the
master
branch
20 times, most recently
from
522a3ad to
8edfe3b
Compare
Megamouse
added
OS: macOS
Build and CI
nastys
force-pushed
the
master
branch
8 times, most recently
from
1edfe6a to
fac3786
Compare
nastys
force-pushed
the
master
branch
4 times, most recently
from
2cd0a00 to
9c1d805
Compare
makigumo
reviewed
Jan 11, 2023
.ci/deploy-mac.sh
Outdated
| @@ -33,7 +35,7 @@ echo "IconIndex=0" >> Quickstart.url | |||
|
|
|||
| DMG_FILEPATH="$BUILD_ARTIFACTSTAGINGDIRECTORY/rpcs3-v${COMM_TAG}-${COMM_COUNT}-${COMM_HASH}_macos.dmg" | |||
|
|
|||
| create-dmg --volname RPCS3 \ | |||
| "/usr/local/Homebrew/bin/create-dmg" --volname RPCS3 \ | |||
There was a problem hiding this comment.
I don't think this path is valid. Should probably be
Suggested change
| "/usr/local/Homebrew/bin/create-dmg" --volname RPCS3 \ | |
| "/usr/local/bin/create-dmg" --volname RPCS3 \ |
or
Suggested change
| "/usr/local/Homebrew/bin/create-dmg" --volname RPCS3 \ | |
| "/usr/local/opt/create-dmg/bin/create-dmg" --volname RPCS3 \ |
makigumo
reviewed
Jan 11, 2023
.ci/deploy-mac.sh
Outdated
| @@ -45,7 +47,7 @@ create-dmg --volname RPCS3 \ | |||
| "$DMG_FILEPATH" \ | |||
| RPCS3.app | |||
|
|
|||
| 7z a -mx9 rpcs3-v"${COMM_TAG}"-"${COMM_COUNT}"-"${COMM_HASH}"_macos.7z RPCS3.app | |||
| "/usr/local/Homebrew/bin/7z" a -mx9 rpcs3-v"${COMM_TAG}"-"${COMM_COUNT}"-"${COMM_HASH}"_macos.7z RPCS3.app | |||
There was a problem hiding this comment.
Same as above
Suggested change
| "/usr/local/Homebrew/bin/7z" a -mx9 rpcs3-v"${COMM_TAG}"-"${COMM_COUNT}"-"${COMM_HASH}"_macos.7z RPCS3.app | |
| "/usr/local/bin/7z" a -mx9 rpcs3-v"${COMM_TAG}"-"${COMM_COUNT}"-"${COMM_HASH}"_macos.7z RPCS3.app |
or
Suggested change
| "/usr/local/Homebrew/bin/7z" a -mx9 rpcs3-v"${COMM_TAG}"-"${COMM_COUNT}"-"${COMM_HASH}"_macos.7z RPCS3.app | |
| "/usr/local/opt/p7zip/bin/7z" a -mx9 rpcs3-v"${COMM_TAG}"-"${COMM_COUNT}"-"${COMM_HASH}"_macos.7z RPCS3.app |
Update macOS build script
nastys
force-pushed
the
master
branch
2 times, most recently
from
60a9963 to
d26905c
Compare
nastys
force-pushed
the
master
branch
2 times, most recently
from
e99e3ca to
0977896
Compare
nastys
changed the title
kd-11
approved these changes
Jan 21, 2023
Megamouse
reviewed
Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.