rsx: Fix exceptions #13082
Merged
rsx: Fix exceptions #13082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
force-pushed
the
patch-11
branch
3 times, most recently
from
2102024 to
4b72921
Compare
kd-11
reviewed
Dec 16, 2022
elad335
force-pushed
the
patch-11
branch
2 times, most recently
from
ac30d30 to
765aaf4
Compare
elad335
force-pushed
the
patch-11
branch
2 times, most recently
from
9513219 to
6367786
Compare
|
Turns out the exception message was actually wrong, it works fine before and after this pr on my pc so the crash is about something more specific currently unknown with specific setups. |
This was referenced Dec 16, 2022
Closed
kd-11
approved these changes
Dec 17, 2022
There was a problem hiding this comment.
Adding all those "invalid" enumerations to enums is pollution and I don't agree with the solution from a design POV.
However, there are no easy/quick solutions to that as it is a design issue in the first place.
I've created #13091 to fix the problems I have with this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the log message in #13075, the anti-corruption mechanism was actually working just fine.
Fixes #9644