Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] vk: Fixup for scissor/viewport invalidation rules #12768

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Oct 7, 2022

Do not release the invalidation flags just because the backend saw them. They need to get loaded as well which happens asynchronously. Deleting the flags makes the bind operation skip updates incorrectly.

Fixes #12766
Fixes #12765

@Nerboruto
Copy link

Nerboruto commented Oct 7, 2022

motorstorm has a weird effect on motion blur and screen shaking that I had never noticed before #12762 I'll try to see if this pr solves it.

@kd-11 kd-11 merged commit 3c88477 into RPCS3:master Oct 7, 2022
@Linear524
Copy link

Massive shadows flickering in GoW Ascention... Something really breaks it this time. Yesterday it was perfectly playable.
(RCB is on and I use Force CPU Blit for this title, otherwise it doesn't boot)

@kd-11
Copy link
Contributor Author

kd-11 commented Oct 7, 2022

Massive shadows flickering in GoW Ascention... Something really breaks it this time. Yesterday it was perfectly playable. (RCB is on and I use Force CPU Blit for this title, otherwise it doesn't boot)

This PR fixed that bug. Update your rpcs3 version. Open a ticket if you can still reproduce.

@kd-11 kd-11 deleted the vk-dynamic-state-fix branch October 16, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants