-
Notifications
You must be signed in to change notification settings - Fork 40
Updated README.md with April 29 results #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
docs/dev-docker/README.md
Outdated
@@ -507,6 +507,9 @@ Use AITER release candidate branch instead: | |||
|
|||
## Changelog | |||
|
|||
20250415_aiter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we keep calling those *_aiter?
Which also reminds me, the above section about using the aiter_integration_final branch is no longer correct, the branch is long deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, I was just matching the names from previous releases - please let me know if there's another name or any notes I should add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not removed? I think something went wrong in the last commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed that section and the "_aiter", if you could advise on what notes to add to the changelog for this container that would be appreciated, otherwise I can remove that entry entirely.
docker build -f docker/Dockerfile.rocm -t <your_tag> --build-arg USE_CYTHON=1 . | ||
``` | ||
|
||
## Changelog | ||
|
||
20250415: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is still there
docs/dev-docker/README.md
Outdated
docker build -f docker/Dockerfile.rocm -t <your_tag> --build-arg USE_CYTHON=1 . | ||
``` | ||
|
||
## Changelog | ||
|
||
20250415: | ||
- To be added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated the note per Teresa's comment in this morning's meeting, let me know if further changes are needed - thanks!
Please direct your PRs to the upstream vllm (https://github.com/vllm-project/vllm.git)
Accepting PRs into the ROCm fork (https://github.com/ROCm/vllm) will require a clear previously communicated exception