Skip to content

Commit

Permalink
Updating CI
Browse files Browse the repository at this point in the history
Update continuous_integration.yml

Update continuous_integration.yml

Adding EMU Runners

Update continuous_integration.yml

Update continuous_integration.yml

Bump thollander/actions-comment-pull-request from 2.5.0 to 3.0.1

Bumps [thollander/actions-comment-pull-request](https://github.com/thollander/actions-comment-pull-request) from 2.5.0 to 3.0.1.
- [Release notes](https://github.com/thollander/actions-comment-pull-request/releases)
- [Commits](thollander/actions-comment-pull-request@v2.5.0...v3.0.1)

---
updated-dependencies:
- dependency-name: thollander/actions-comment-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Update continuous_integration.yml

Update continuous_integration.yml

Update run-ci.py

Update upload-image-to-github.py

Update continuous_integration.yml

Update continuous_integration.yml

Update continuous_integration.yml

Update continuous_integration.yml

Update continuous_integration.yml

using github output

Update continuous_integration.yml

Revert temp change

Update continuous_integration.yml

Update continuous_integration.yml
  • Loading branch information
ammarwa committed Nov 23, 2024
1 parent 7ddc72a commit d564f75
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 22 deletions.
54 changes: 34 additions & 20 deletions .github/workflows/continuous_integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
strategy:
fail-fast: false
matrix:
runner: ['mi200', 'mi300']
runner: ['mi200-emu', 'mi300-emu']
os: ['ubuntu-22.04']
build-type: ['RelWithDebInfo']
ci-flags: ['--linter clang-tidy']
Expand Down Expand Up @@ -156,8 +156,8 @@ jobs:
strategy:
fail-fast: false
matrix:
runner: ['mi300']
os: ['rhel', 'sles']
runner: ['mi300-emu']
os: ['rhel-emu', 'sles-emu']
build-type: ['RelWithDebInfo']
ci-flags: ['--linter clang-tidy']

Expand Down Expand Up @@ -275,9 +275,9 @@ jobs:
code-coverage:
strategy:
fail-fast: false
# fail-fast: false
matrix:
runner: ['mi200']
runner: ['mi300-emu']
os: ['ubuntu-22.04']
build-type: ['Release']

Expand Down Expand Up @@ -412,7 +412,8 @@ jobs:
path: |
.codecov/*.xml
- name: Generate Code Coverage Comment
- id: generatereport
name: Generate Code Coverage Comment
if: github.event_name == 'pull_request'
timeout-minutes: 5
shell: bash
Expand All @@ -427,7 +428,7 @@ jobs:
which -a git
git --version
./source/scripts/upload-image-to-github.py --bot --token ${{ github.token }} --files .codecov/{all,tests,samples}.png --output-dir .codecov --name pr-${{ github.event.pull_request.number }}
./source/scripts/upload-image-to-github.py --bot --token ${{ secrets.TOKEN }} --files .codecov/{all,tests,samples}.png --output-dir .codecov --name pr-${{ github.event.pull_request.number }}
echo -e "\n${PWD}:"
ls -la .
Expand All @@ -451,13 +452,26 @@ jobs:
EOF
echo 'CODECOVERAGE_REPORT<<EOF' > $GITHUB_OUTPUT
cat .codecov/report.md >> $GITHUB_OUTPUT
echo 'EOF' >> $GITHUB_OUTPUT
- name: Write Code Coverage Comment
if: github.event_name == 'pull_request'
timeout-minutes: 5
uses: thollander/actions-comment-pull-request@v2.5.0
uses: actions/github-script@v6
env:
COMMENT_BODY: ${{ steps.generatereport.outputs.CODECOVERAGE_REPORT }}
with:
comment_tag: codecov-report
filePath: .codecov/report.md
github-token: ${{ secrets.TOKEN }}
script: |
const comment_body = process.env.COMMENT_BODY;
github.rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: comment_body
})
- name: Archive Code Coverage Data
uses: actions/upload-artifact@v4
Expand Down Expand Up @@ -504,20 +518,20 @@ jobs:
strategy:
fail-fast: false
matrix:
runner: ['mi200', 'mi300']
runner: ['mi200-emu', 'mi300-emu']
sanitizer: ['AddressSanitizer', 'ThreadSanitizer', 'LeakSanitizer', 'UndefinedBehaviorSanitizer']
os: ['ubuntu-22.04']
build-type: ['RelWithDebInfo']
exclude:
# - { runner: 'navi3', sanitizer: 'ThreadSanitizer' }
# - { runner: 'navi3', sanitizer: 'LeakSanitizer' }
# - { runner: 'vega20', sanitizer: 'AddressSanitizer' }
# - { runner: 'vega20', sanitizer: 'LeakSanitizer' }
- { runner: 'mi200', sanitizer: 'LeakSanitizer' }
- { runner: 'mi200', sanitizer: 'AddressSanitizer' }
# - { runner: 'mi300', sanitizer: 'AddressSanitizer' }
- { runner: 'mi300', sanitizer: 'ThreadSanitizer' }
- { runner: 'mi300', sanitizer: 'UndefinedBehaviorSanitizer' }
# - { runner: 'navi3-emu', sanitizer: 'ThreadSanitizer' }
# - { runner: 'navi3-emu', sanitizer: 'LeakSanitizer' }
# - { runner: 'vega20-emu', sanitizer: 'AddressSanitizer' }
# - { runner: 'vega20-emu', sanitizer: 'LeakSanitizer' }
- { runner: 'mi200-emu', sanitizer: 'LeakSanitizer' }
- { runner: 'mi200-emu', sanitizer: 'AddressSanitizer' }
# - { runner: 'mi300-emu', sanitizer: 'AddressSanitizer' }
- { runner: 'mi300-emu', sanitizer: 'ThreadSanitizer' }
- { runner: 'mi300-emu', sanitizer: 'UndefinedBehaviorSanitizer' }

if: ${{ contains(github.event_name, 'pull_request') }}
runs-on: ${{ matrix.runner }}-runner-set
Expand Down
2 changes: 1 addition & 1 deletion source/scripts/run-ci.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# and default value for CTEST_SUBMIT_URL
# _PROJECT_NAME = "rocprofiler-v2-internal"
# _BASE_URL = "10.194.116.31/cdash"
_PROJECT_NAME = "rocprofiler-sdk-internal"
_PROJECT_NAME = "rocprofiler-sdk-emu"
_BASE_URL = "cdash.rocprofiler.amd.com"
_GCOVR_GENERATE_CMD = None

Expand Down
2 changes: 1 addition & 1 deletion source/scripts/upload-image-to-github.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def run(*args, **kwargs):
"--repo-url",
help="Base GitHub repo URL",
type=str,
default="https://github.com/ROCm/rocprofiler-sdk-internal",
default="https://github.com/AMD-ROCm-Internal/rocprofiler-sdk-internal",
)
parser.add_argument(
"-o",
Expand Down

0 comments on commit d564f75

Please sign in to comment.