[rocprofiler-systems] Fix how GFX targets are passed to RCCL and add workflow that builds with all GFX targets#3568
Draft
kcossett-amd wants to merge 4 commits intodevelopfrom
Draft
Conversation
github-actions
bot
added
project: rocprofiler-systems
github actions
Contributor
Author
|
Formatting failure is for |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in how GFX targets are passed to RCCL's Makefile and adds a new CI workflow to test building with all supported GPU architectures. The bug fix converts CMake's semicolon-separated list format to a space-separated string that the RCCL Makefile expects. The new workflow ensures that future changes don't break compilation with multiple GFX targets.
Changes:
- Fixed RCCL build by converting GFX target list from CMake format (semicolons) to space-separated format expected by Make
- Added new GitHub Actions workflow to build against all supported GFX targets with ROCm 7.1
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/rocprofiler-systems/examples/rccl/CMakeLists.txt | Converts RCCL_GPU_TARGETS from CMake list to space-separated string before passing to make command |
| .github/workflows/rocprofiler-systems-build-all-targets.yml | New workflow that builds rocprofiler-systems with all supported GFX targets to prevent future build regressions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Found this bug while attempting to fix another issue. If multiple
ROCPROFSYS_GFX_TARGETSare detected,rcclfails to build examples and terminates build.To avoid anything like this going unnoticed in the future, add a workflow that builds against ROCm 7.1 and uses all supported gfx targets.
Technical Details
Pass a space separated list to RCCL
Add
rocprofiler-systems-build-all-targets.yml, whose sole purpose is to test that the build succeeds with multiple GFX targets. No tests are actually ran.JIRA ID
AIPROFSYST-221
Test Plan
Locally
New workflow (
[rocprofiler-systems Build All GPU Targets / build-all-targets (pull_request)]Test Result
Locally - PASSED
New workflow - PASSED - Requires ~40 minutes
Submission Checklist