Skip to content

Simplify MPI trace merge logic and remove legacy guards#3562

Open
marantic-amd wants to merge 1 commit intodevelopfrom
users/marantic-amd/resolve_perfetto_mpi_merge_in_cache_manager
Open

Simplify MPI trace merge logic and remove legacy guards#3562
marantic-amd wants to merge 1 commit intodevelopfrom
users/marantic-amd/resolve_perfetto_mpi_merge_in_cache_manager

Conversation

@marantic-amd
Copy link
Contributor

Motivation

Remove conditional MPI compilation guards from perfetto trace merging
functionality to unify code paths. The merge logic now executes
unconditionally when ROCPROFSYS_PERFETTO_COMBINE_TRACES is enabled,
relying on MPI barrier and rank checks at runtime instead of
compile-time conditionals.

Technical Details

  • Remove #if ROCPROFSYS_USE_MPI guards from get_perfetto_combined_traces()
    to allow configuration reading regardless of MPI availability
  • Extract merge logic into dedicated merge_perfetto_files() function in
    filesystem_utils namespace for better organization
  • Move merge script execution from cache_manager::post_process_bulk()
    into the new merge_perfetto_files() function
  • Update mpi-perfetto-merge test to remove ROCPROFSYS_TRACE_LEGACY=ON
    requirement, as trace combining no longer depends on legacy mode

JIRA ID

ROCM-2141

Test Plan

  • Existing and updated tests run.

Test Result

  • Tests are passing on workstation machines

Submission Checklist

@marantic-amd marantic-amd requested review from a team and jrmadsen as code owners February 26, 2026 11:00
@marantic-amd marantic-amd force-pushed the users/marantic-amd/resolve_perfetto_mpi_merge_in_cache_manager branch from 1da63c2 to 913679f Compare February 26, 2026 11:08
@marantic-amd marantic-amd force-pushed the users/marantic-amd/resolve_perfetto_mpi_merge_in_cache_manager branch from 913679f to 52744fb Compare February 26, 2026 13:23
@marantic-amd marantic-amd force-pushed the users/marantic-amd/resolve_perfetto_mpi_merge_in_cache_manager branch from 52744fb to 19beb09 Compare February 26, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant