Simplify MPI trace merge logic and remove legacy guards#3562
Open
marantic-amd wants to merge 1 commit intodevelopfrom
Open
Simplify MPI trace merge logic and remove legacy guards#3562marantic-amd wants to merge 1 commit intodevelopfrom
marantic-amd wants to merge 1 commit intodevelopfrom
Conversation
1da63c2 to
913679f
Compare
913679f to
52744fb
Compare
52744fb to
19beb09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Remove conditional MPI compilation guards from perfetto trace merging
functionality to unify code paths. The merge logic now executes
unconditionally when ROCPROFSYS_PERFETTO_COMBINE_TRACES is enabled,
relying on MPI barrier and rank checks at runtime instead of
compile-time conditionals.
Technical Details
to allow configuration reading regardless of MPI availability
filesystem_utils namespace for better organization
into the new merge_perfetto_files() function
requirement, as trace combining no longer depends on legacy mode
JIRA ID
ROCM-2141
Test Plan
Test Result
Submission Checklist