Support Nvidia build on theRock for HIP-tests#3335
Open
Conversation
litvaOo
force-pushed
the
dev/amd/dlytovch/therock-nvidia
branch
from
4e15013 to
86fef42
Compare
litvaOo
force-pushed
the
dev/amd/dlytovch/therock-nvidia
branch
from
86fef42 to
e4a966e
Compare
litvaOo
force-pushed
the
dev/amd/dlytovch/therock-nvidia
branch
2 times, most recently
from
3cc1bbf to
9a96157
Compare
litvaOo
force-pushed
the
dev/amd/dlytovch/therock-nvidia
branch
6 times, most recently
from
b6f1dba to
0c2eb76
Compare
emankov
requested changes
Feb 26, 2026
emankov
left a comment
emankov
left a comment
There was a problem hiding this comment.
This is a good start on getting the NVIDIA CI green, but there are a few critical issues here - including segfault risks, race conditions, and some heavy CMake redundancies - that need to be addressed before this can be merged.
projects/hipother/hipnv/include/hip/nvidia_detail/nvidia_hip_runtime_api.h
Show resolved
Hide resolved
projects/hipother/hipnv/include/hip/nvidia_detail/nvidia_hip_runtime_api.h
Outdated
Show resolved
Hide resolved
projects/hipother/hipnv/include/hip/nvidia_detail/nvidia_hip_runtime_api.h
Outdated
Show resolved
Hide resolved
projects/hipother/hipnv/include/hip/nvidia_detail/nvidia_hip_runtime_api.h
Show resolved
Hide resolved
projects/hipother/hipnv/include/hip/nvidia_detail/nvidia_hip_runtime_api.h
Outdated
Show resolved
Hide resolved
chrispaquot
approved these changes
Feb 26, 2026
|
Sorry, @chrispaquot, I don't think this PR is ready to merge due to critical issues. |
…tMemPool on Nvidia implementation
…djust enum conversions for hipother
litvaOo
force-pushed
the
dev/amd/dlytovch/therock-nvidia
branch
from
ca84502 to
426065f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current implementation of hip-tests CMakeLists.txt does not support build of hip-tests on Nvidia. This PR adds corresponding support
Technical Details
This PR mainly does two things:
Additionally, some fixes for hipother to fix compatibility with multiple CUDA version are added: namely workarounds for mismatch between driver and runtime memory location types and Nvidia guards for some tests.
NOTE: some tests are disabled due to currently unresolvable issues with CUDA compatibility, e.g lack of hipStreamGetCaptureInfo_V2 in latest CUDA. These fixes are out of scope for this PR and require separate PR discussion
JIRA ID
NA
Test Plan
HIP-tests should be built successfully as-is on the current TheRock setup, and successfully built for NVidia
Test Result
Nvidia built passing locally, not running in CI yet due to lack of the infrastructure.
AMD build passing locally, waiting for PSDB to pass
Submission Checklist