[rocprofiler-sdk] Enable codecov and Improve CI stablity#3279
Open
venkat1361 wants to merge 21 commits intodevelopfrom
Open
[rocprofiler-sdk] Enable codecov and Improve CI stablity#3279venkat1361 wants to merge 21 commits intodevelopfrom
venkat1361 wants to merge 21 commits intodevelopfrom
Conversation
venkat1361
changed the title
github-actions
bot
added
the
github actions
venkat1361
force-pushed
the
users/venkat1361/codecov-enable
branch
from
50a9a2b to
b73960a
Compare
Contributor
Author
|
The pc-sampling-integration-test-client uses disassembly.hpp header which calls amd_comgr functions (e.g., amd_comgr_create_data) but was not linking against the amd_comgr library, causing undefined symbol errors at runtime.
venkat1361
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves CI stability and enables code coverage for rocprofiler-sdk by dynamically sourcing the ROCm version from installed metadata instead of hardcoding it, re-enabling the code coverage workflow, and adding a missing dependency.
Changes:
- Dynamically source ROCM_VERSION from
/opt/rocm/.info/versionvia BASH_ENV in Docker containers instead of hardcoding in workflow files - Re-enable code coverage workflow with updated runner (mi325 instead of mi300a) and aligned CMAKE options
- Add amd_comgr dependency to pc_sampling integration test
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| projects/rocprofiler-sdk/docker/Dockerfile.ci | Added validation and dynamic export of ROCM_VERSION from installed ROCm metadata via BASH_ENV |
| .github/workflows/rocprofiler-sdk-docs.yml | Removed hardcoded ROCM_VERSION env variable; now uses dynamically sourced version |
| .github/workflows/rocprofiler-sdk-continuous_integration.yml | Removed hardcoded ROCM_VERSION env variable; now uses dynamically sourced version |
| .github/workflows/rocprofiler-sdk-code_coverage.yml | Re-enabled workflow, removed hardcoded ROCM_VERSION, changed runner to mi325, added CMAKE options |
| .github/workflows/aqlprofile-continuous_integration.yml | Removed hardcoded ROCM_VERSION env variable; now uses dynamically sourced version |
| projects/rocprofiler-sdk/tests/pc_sampling/CMakeLists.txt | Added amd_comgr package dependency required for the test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
JIRA ID
Test Plan
Test Result
Submission Checklist