[rocprofiler-systems] Add MPI rank/size and configuration to rocpd_process metadata#3012
Open
mradosav-amd wants to merge 7 commits intodevelopfrom
Open
[rocprofiler-systems] Add MPI rank/size and configuration to rocpd_process metadata#3012mradosav-amd wants to merge 7 commits intodevelopfrom
mradosav-amd wants to merge 7 commits intodevelopfrom
Conversation
dgaliffiAMD
reviewed
Feb 3, 2026
Contributor
dgaliffiAMD
left a comment
There was a problem hiding this comment.
Please see comments below. It looks good overall. Thank you.
projects/rocprofiler-systems/source/lib/rocprof-sys/library.cpp
Outdated
Show resolved
Hide resolved
projects/rocprofiler-systems/source/lib/rocprof-sys/library.cpp
Outdated
Show resolved
Hide resolved
projects/rocprofiler-systems/source/lib/rocprof-sys/library.cpp
Outdated
Show resolved
Hide resolved
sputhala-amd
reviewed
Feb 4, 2026
projects/rocprofiler-systems/source/lib/rocprof-sys/library/components/mpi_gotcha.cpp
Outdated
Show resolved
Hide resolved
1b7c28c to
235232a
Compare
marantic-amd
approved these changes
Feb 12, 2026
235232a to
8520a34
Compare
8520a34 to
b96b7e2
Compare
b96b7e2 to
d424472
Compare
d424472 to
f1ecd95
Compare
4a4d416 to
e4dba6d
Compare
47a828d to
21bfc98
Compare
21bfc98 to
283cc70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When profiling MPI applications, the rocpd database's
rocpd_processtable lacked critical context about the MPI environment (rank, communicator size) and profiler configuration settings. This made it difficult to correlate profiling data with specific MPI processes and understand the configuration used during profiling.Technical Details
processmetadata struct withenvironmentandextdataJSON fieldsprint_settings_json()to serialize profiler configuration to JSON formatmpi_gotchato captureMPI_COMM_WORLD_RANKand
MPI_COMM_WORLD_SIZEafter MPI initializationextdatacolumn; MPI environment inenvironmentcolumnJIRA ID
AIPROFSYST-175
Test Plan
rocpd_process.environmentrocpd_process.extdataTest Result
rocpd_processtable should contain JSON withMPI_COMM_WORLD_RANKandMPI_COMM_WORLD_SIZEfor each MPI processextdatacolumn should contain JSON with all non-hidden, enabled configuration settings (e.g.,ROCPROFSYS_OUTPUT_PATH, sampling settings, etc.)Submission Checklist