fix(ck): Stream-K Tile Engine GPU Query Fix by arai713 · Pull Request #8086 · ROCm/rocm-libraries

arai713 · 2026-06-04T23:28:28Z

Motivation

The Stream-K tile engine validation utilities call rocminfo at build time to detect the GPU architecture, which prevents building on CPU-only nodes. The GPU target is already known from CMake's SUPPORTED_GPU_TARGETS, so runtime hardware detection is unnecessary during code generation.

Technical Details

The gemm_streamk_validation_utils.py file used subprocess.check_output(["rocminfo"]) to query GPU hardware at CMake configure time. This call originated from get_gpu_name_by_id() and used during tile configuration validation. On CPU-only build nodes, this fails because rocminfo either doesn't exist or returns no GPU devices. The main changes are as follows:

Removed runtime GPU detection infrastructure: deleted get_gpu_name_by_id(), set_gpu_targets(), get_configured_gpu_targets(), the _configured_gpu_targets module variable, and the GPU_NAME_PATTERN regex.
Added gpu_target as an explicit parameter. is_tile_config_valid(), validate_gemm(), validate_warp_tile_combination(), validate_warp_configuration(), and validate_lds_capacity() now accept gpu_target as a required parameter instead of querying hardware internally. The corresponding changes were also made in gemm_streamk_instance_builder.py and CMakeLists.txt
Added WARP_SUPPORTED_COMBINATIONS for per-GPU warp config validation, and LDS_SIZE_MAP / DEFAULT_LDS_SIZE for GPU-aware LDS capacity checks.

Test Plan

The benchmarks were compiled and run on a GPU as well as a CPU only node to verify correctness.

Test Result

All tests passed

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

…xplicit parameter from CMake

Copilot

Pull request overview

This PR removes build-time GPU hardware probing (rocminfo) from the Stream-K tile engine validation path and instead threads the configured GPU target(s) from CMake into the Python validation/generation utilities, enabling builds on CPU-only nodes.

Changes:

Removed runtime GPU detection and made validation functions accept an explicit gpu_target.
Added per-GPU validation data for warp configuration and LDS capacity budgeting.
Updated CMake/Python instance generation plumbing to pass --gpu_targets, and added a small pytest file to validate LDS sizing behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File	Description
projects/composablekernel/tile_engine/ops/gemm_streamk/test_lds_capacity.py	Adds pytest coverage for GPU-aware LDS capacity validation.
projects/composablekernel/tile_engine/ops/gemm_streamk/gemm_streamk_validation_utils.py	Removes `rocminfo` querying and makes validation GPU-target-driven (warp + LDS).
projects/composablekernel/tile_engine/ops/gemm_streamk/gemm_streamk_instance_builder.py	Passes configured GPU targets into validation instead of probing hardware.
projects/composablekernel/tile_engine/ops/gemm_streamk/CMakeLists.txt	Updates custom commands to pass `--gpu_targets` to the instance builder.

Comments suppressed due to low confidence (1)

projects/composablekernel/tile_engine/ops/gemm_streamk/gemm_streamk_validation_utils.py:265

validate_warp_tile_combination looks up WARP_TILE_SUPPORTED_COMBINATIONS using the raw gpu_name. If callers pass full targets like gfx942:xnack+, the lookup misses and the function becomes permissive (and emits warnings). Normalize the GPU name similarly to validate_lds_capacity by stripping any :... suffix before the lookup/logging.

    """Validate warp tile combination against GPU-specific supported combinations."""
    # Construct the key for looking up supported combinations
    warp_tile_key = f"{a_datatype}_{b_datatype}_{c_datatype}"
    current_combination = [warp_tile_m, warp_tile_n, warp_tile_k]

    # Check if we have GPU-specific combinations
    gpu_warp_tile_combinations = WARP_TILE_SUPPORTED_COMBINATIONS.get(gpu_name, {})
    if not gpu_warp_tile_combinations:
        # If GPU not recognized, try to be permissive but log warning
        logging.warning(f"No warp tile combinations found for GPU: {gpu_name}")
        return True, ""

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

therock-pr-bot · 2026-07-11T00:10:23Z

✅ All Checks Passed — Ready for Review

Check	Status	Details
🌿 Branch Name	✅ Pass	—
📝 PR Title/Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	—
🔎 pre-commit	✅ Pass	—
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—
🤖 therock-pr-bot	✅ Pass	—

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

therock-pr-bot · 2026-07-11T00:10:24Z

🎉 All checks passed! This PR is ready for review.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

tenpercent

comments were addressed and ci is passing. thanks!

fix(ck): Stream-K Tile Engine GPU Query Fix ## Motivation The Stream-K tile engine validation utilities call rocminfo at build time to detect the GPU architecture, which prevents building on CPU-only nodes. The GPU target is already known from CMake's SUPPORTED_GPU_TARGETS, so runtime hardware detection is unnecessary during code generation. ## Technical Details The gemm_streamk_validation_utils.py file used subprocess.check_output(["rocminfo"]) to query GPU hardware at CMake configure time. This call originated from get_gpu_name_by_id() and used during tile configuration validation. On CPU-only build nodes, this fails because rocminfo either doesn't exist or returns no GPU devices. The main changes are as follows: - Removed runtime GPU detection infrastructure: deleted get_gpu_name_by_id(), set_gpu_targets(), get_configured_gpu_targets(), the _configured_gpu_targets module variable, and the GPU_NAME_PATTERN regex. - Added gpu_target as an explicit parameter. is_tile_config_valid(), validate_gemm(), validate_warp_tile_combination(), validate_warp_configuration(), and validate_lds_capacity() now accept gpu_target as a required parameter instead of querying hardware internally. The corresponding changes were also made in gemm_streamk_instance_builder.py and CMakeLists.txt - Added WARP_SUPPORTED_COMBINATIONS for per-GPU warp config validation, and LDS_SIZE_MAP / DEFAULT_LDS_SIZE for GPU-aware LDS capacity checks. ## Test Plan The benchmarks were compiled and run on a GPU as well as a CPU only node to verify correctness. ## Test Result All tests passed ## Related JIRA ID : AICK-1635 ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

## Motivation The Stream-K tile engine validation utilities call rocminfo at build time to detect the GPU architecture, which prevents building on CPU-only nodes. The GPU target is already known from CMake's SUPPORTED_GPU_TARGETS, so runtime hardware detection is unnecessary during code generation. ## Technical Details The gemm_streamk_validation_utils.py file used subprocess.check_output(["rocminfo"]) to query GPU hardware at CMake configure time. This call originated from get_gpu_name_by_id() and used during tile configuration validation. On CPU-only build nodes, this fails because rocminfo either doesn't exist or returns no GPU devices. The main changes are as follows: - Removed runtime GPU detection infrastructure: deleted get_gpu_name_by_id(), set_gpu_targets(), get_configured_gpu_targets(), the _configured_gpu_targets module variable, and the GPU_NAME_PATTERN regex. - Added gpu_target as an explicit parameter. is_tile_config_valid(), validate_gemm(), validate_warp_tile_combination(), validate_warp_configuration(), and validate_lds_capacity() now accept gpu_target as a required parameter instead of querying hardware internally. The corresponding changes were also made in gemm_streamk_instance_builder.py and CMakeLists.txt - Added WARP_SUPPORTED_COMBINATIONS for per-GPU warp config validation, and LDS_SIZE_MAP / DEFAULT_LDS_SIZE for GPU-aware LDS capacity checks. ## Test Plan The benchmarks were compiled and run on a GPU as well as a CPU only node to verify correctness. ## Test Result All tests passed ## Related JIRA ID : AICK-1635 ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Maksim (Max) Podkorytov <Maksim.Podkorytov@amd.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

fix(ck): Stream-K Tile Engine GPU Query Fix ## Motivation The Stream-K tile engine validation utilities call rocminfo at build time to detect the GPU architecture, which prevents building on CPU-only nodes. The GPU target is already known from CMake's SUPPORTED_GPU_TARGETS, so runtime hardware detection is unnecessary during code generation. ## Technical Details The gemm_streamk_validation_utils.py file used subprocess.check_output(["rocminfo"]) to query GPU hardware at CMake configure time. This call originated from get_gpu_name_by_id() and used during tile configuration validation. On CPU-only build nodes, this fails because rocminfo either doesn't exist or returns no GPU devices. The main changes are as follows: - Removed runtime GPU detection infrastructure: deleted get_gpu_name_by_id(), set_gpu_targets(), get_configured_gpu_targets(), the _configured_gpu_targets module variable, and the GPU_NAME_PATTERN regex. - Added gpu_target as an explicit parameter. is_tile_config_valid(), validate_gemm(), validate_warp_tile_combination(), validate_warp_configuration(), and validate_lds_capacity() now accept gpu_target as a required parameter instead of querying hardware internally. The corresponding changes were also made in gemm_streamk_instance_builder.py and CMakeLists.txt - Added WARP_SUPPORTED_COMBINATIONS for per-GPU warp config validation, and LDS_SIZE_MAP / DEFAULT_LDS_SIZE for GPU-aware LDS capacity checks. ## Test Plan The benchmarks were compiled and run on a GPU as well as a CPU only node to verify correctness. ## Test Result All tests passed ## Related JIRA ID : AICK-1635 ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Maksim (Max) Podkorytov <Maksim.Podkorytov@amd.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

github-actions Bot added the project: composablekernel label Jun 4, 2026

arai713 changed the title ~~remove rocminfo usage and refactored to accept the GPU target as an e…~~ [TILE_ENGINE] Stream-K Tile Engine GPU Query Fix Jun 4, 2026

assistant-librarian Bot added the organization: ROCm label Jun 4, 2026

illsilin assigned cgmillette Jun 5, 2026

arai713 force-pushed the users/arai/ck/streamk_tile_engine_gpu_fix branch 2 times, most recently from ed06956 to 643cb67 Compare June 10, 2026 18:32

arai713 marked this pull request as ready for review June 11, 2026 18:59

arai713 requested a review from a team as a code owner June 11, 2026 18:59

remove rocminfo usage and refactored to accept the GPU target as an e…

9e6419c

…xplicit parameter from CMake

arai713 force-pushed the users/arai/ck/streamk_tile_engine_gpu_fix branch 2 times, most recently from cb9ab37 to d2907e1 Compare June 18, 2026 00:07

tenpercent requested a review from Copilot June 18, 2026 18:59

Copilot started reviewing on behalf of tenpercent June 18, 2026 19:00 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

arai713 force-pushed the users/arai/ck/streamk_tile_engine_gpu_fix branch from d2907e1 to 2f42c5d Compare June 22, 2026 18:43

tenpercent and others added 3 commits June 22, 2026 16:52

Merge branch 'develop' into users/arai/ck/streamk_tile_engine_gpu_fix

e71b911

Add LDS capacity unit tests for per-GPU validation

0e2417c

Changes from review: code cleanup

eedd197

arai713 force-pushed the users/arai/ck/streamk_tile_engine_gpu_fix branch from 2f42c5d to eedd197 Compare June 22, 2026 20:53

tenpercent requested a review from Copilot June 22, 2026 22:38

Copilot started reviewing on behalf of tenpercent June 22, 2026 22:39 View session

Copilot AI reviewed Jun 22, 2026

View reviewed changes

arai713 and others added 2 commits July 10, 2026 20:05

review fixes

ac76758

Merge branch 'develop' into users/arai/ck/streamk_tile_engine_gpu_fix

da13d95

therock-pr-bot Bot added the Not ready to Review label Jul 11, 2026

arai713 changed the title ~~[TILE_ENGINE] Stream-K Tile Engine GPU Query Fix~~ fix(ck): Stream-K Tile Engine GPU Query Fix Jul 11, 2026

therock-pr-bot Bot removed the Not ready to Review label Jul 11, 2026

Merge branch 'develop' into users/arai/ck/streamk_tile_engine_gpu_fix

8b9a74a

tenpercent requested a review from Copilot July 23, 2026 23:53

tenpercent self-assigned this Jul 23, 2026

Copilot started reviewing on behalf of tenpercent July 23, 2026 23:56 View session

Copilot AI reviewed Jul 24, 2026

View reviewed changes

Comment thread projects/composablekernel/tile_engine/ops/gemm_streamk/test_lds_capacity.py Outdated

Potential fix for pull request finding

a2f9c83

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

tenpercent approved these changes Jul 24, 2026

View reviewed changes

arai713 merged commit 33e2420 into develop Jul 24, 2026
29 checks passed

arai713 deleted the users/arai/ck/streamk_tile_engine_gpu_fix branch July 24, 2026 17:28

Navigation Menu

Uh oh!

fix(ck): Stream-K Tile Engine GPU Query Fix - #8086

fix(ck): Stream-K Tile Engine GPU Query Fix#8086
arai713 merged 8 commits into
developfrom
users/arai/ck/streamk_tile_engine_gpu_fix

arai713 commented Jun 4, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

therock-pr-bot Bot commented Jul 11, 2026 •

edited

Loading

Uh oh!

therock-pr-bot Bot commented Jul 11, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

tenpercent left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

arai713 commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Test Plan

Test Result

Related

Submission Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

therock-pr-bot Bot commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ All Checks Passed — Ready for Review

Uh oh!

therock-pr-bot Bot commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

tenpercent left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

arai713 commented Jun 4, 2026 •

edited

Loading

therock-pr-bot Bot commented Jul 11, 2026 •

edited

Loading

therock-pr-bot Bot commented Jul 11, 2026 •

edited

Loading