Skip to content

[CK_Tile] Add scale16 Support for F4 WMMA in CK_Tile - #7677

Merged
tywuAMD merged 7 commits into
developfrom
users/tianyuwu/ck/aick-671
May 30, 2026
Merged

[CK_Tile] Add scale16 Support for F4 WMMA in CK_Tile#7677
tywuAMD merged 7 commits into
developfrom
users/tianyuwu/ck/aick-671

Conversation

@tywuAMD

@tywuAMD tywuAMD commented May 21, 2026

Copy link
Copy Markdown
Contributor

Motivation

This PR adds CK Tile support for the scale16 F4 WMMA path on gfx1250 and improves warp GEMM unit test coverage/structure for gfx1250-specific cases.

Technical Details

  • Scale16 support in warp GEMM dispatch and WMMA trait plumbing: added IsScale16 plumbing to warp GEMM dispatcher path
  • Warp GEMM test restructuring for gfx1250: added Warp GEMM gfx1250 coverage to verify all F4 WMMA paths

Test Plan

Run ./test_ck_tile_wg_32x16x128_fp4.

Test Result

./test_ck_tile_wg_32x16x128_fp4
[----------] Global test environment tear-down
[==========] 3 tests from 1 test suite ran. (1751 ms total)
[  PASSED  ] 3 tests.

Submission Checklist

tywuAMD added 2 commits May 21, 2026 09:07
Signed-off-by: TianyuanWu <Tianyuan.Wu@amd.com>
Signed-off-by: TianyuanWu <Tianyuan.Wu@amd.com>

@AMD-mkulikow AMD-mkulikow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geyyer geyyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you check the CI tests, looks like something else depends on the API you updated.

Signed-off-by: Tianyuan Wu <Tianyuan.Wu@amd.com>
@tywuAMD

tywuAMD commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

The CI result is clean now, but I still need an approval from @ROCm/ck-reviewers to get this PR merged.

@tywuAMD
tywuAMD enabled auto-merge (squash) May 26, 2026 08:09
@tywuAMD
tywuAMD disabled auto-merge May 26, 2026 08:10
@tywuAMD
tywuAMD enabled auto-merge (squash) May 26, 2026 08:10
@tywuAMD
tywuAMD merged commit 308af93 into develop May 30, 2026
34 checks passed
@tywuAMD
tywuAMD deleted the users/tianyuwu/ck/aick-671 branch May 30, 2026 01:27
assistant-librarian Bot pushed a commit to ROCm/composable_kernel that referenced this pull request May 30, 2026
[CK_Tile] Add scale16 Support for F4 WMMA in CK_Tile

## Motivation
This PR adds CK Tile support for the scale16 F4 WMMA path on gfx1250 and
improves warp GEMM unit test coverage/structure for gfx1250-specific
cases.

## Technical Details

- Scale16 support in warp GEMM dispatch and WMMA trait plumbing: added
IsScale16 plumbing to warp GEMM dispatcher path
- Warp GEMM test restructuring for gfx1250: added Warp GEMM gfx1250
coverage to verify all F4 WMMA paths

## Test Plan
Run ./test_ck_tile_wg_32x16x128_fp4.

## Test Result
```
./test_ck_tile_wg_32x16x128_fp4
[----------] Global test environment tear-down
[==========] 3 tests from 1 test suite ran. (1751 ms total)
[  PASSED  ] 3 tests.
```

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
shumway pushed a commit to ROCm/composable_kernel that referenced this pull request Aug 18, 2026
[CK_Tile] Add scale16 Support for F4 WMMA in CK_Tile

## Motivation
This PR adds CK Tile support for the scale16 F4 WMMA path on gfx1250 and
improves warp GEMM unit test coverage/structure for gfx1250-specific
cases.

## Technical Details

- Scale16 support in warp GEMM dispatch and WMMA trait plumbing: added
IsScale16 plumbing to warp GEMM dispatcher path
- Warp GEMM test restructuring for gfx1250: added Warp GEMM gfx1250
coverage to verify all F4 WMMA paths

## Test Plan
Run ./test_ck_tile_wg_32x16x128_fp4.

## Test Result
```
./test_ck_tile_wg_32x16x128_fp4
[----------] Global test environment tear-down
[==========] 3 tests from 1 test suite ran. (1751 ms total)
[  PASSED  ] 3 tests.
```

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

---------

Signed-off-by: TianyuanWu <Tianyuan.Wu@amd.com>
Signed-off-by: Tianyuan Wu <Tianyuan.Wu@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants