Skip to content

feat(ck): add SPIR-V target support - #6304

Merged
geyyer merged 22 commits into
ROCm:developfrom
aobolensk:ck-spirv
Aug 3, 2026
Merged

feat(ck): add SPIR-V target support#6304
geyyer merged 22 commits into
ROCm:developfrom
aobolensk:ck-spirv

Conversation

@aobolensk

@aobolensk aobolensk commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Add initial support for the amdgcnspirv target in Composable Kernel, enabling target-agnostic SPIR-V compilation that is JIT-compiled to native code at runtime

JIRA ID - ROCM-27738

Motivation

Enable Composable Kernel to compile with the SPIR-V target, producing target-agnostic SPIR-V binaries that are JIT-compiled to native GPU ISA at runtime via comgr.

Technical Details

Test Plan

  • Built with GPU_TARGETS=gfx90a;amdgcnspirv
  • Compared wall time (native vs SPIR-V), cold/hot runs

Test Result

Submission Checklist

Add initial support for the amdgcnspirv target in Composable Kernel,
enabling target-agnostic SPIR-V compilation that is JIT-compiled to
native code at runtime
@aobolensk aobolensk changed the title [CK] Add SPIR-V target support CK: Add SPIR-V target support Apr 9, 2026
@aobolensk
aobolensk requested a review from AlexVlx April 13, 2026 09:28
Comment thread projects/composablekernel/include/ck/ck.hpp Outdated
Comment thread projects/composablekernel/include/ck_tile/core/arch/arch.hpp Outdated
Comment thread projects/composablekernel/include/ck/ck.hpp Outdated
Comment thread projects/composablekernel/include/ck/ck.hpp Outdated
Comment thread projects/composablekernel/include/ck/ck.hpp
@aobolensk
aobolensk marked this pull request as ready for review April 22, 2026 06:45
@aobolensk
aobolensk requested a review from a team as a code owner April 22, 2026 06:45
@aobolensk

Copy link
Copy Markdown
Contributor Author

@AlexVlx please take a look, I have addressed the comments

@aobolensk
aobolensk requested a review from AlexVlx April 27, 2026 07:51
@illsilin

Copy link
Copy Markdown
Contributor

Trying to clear the backlog of PRs. resolved a little conflict and fixed clang format in this branch, trying to see if it clears the CI.

@aobolensk

Copy link
Copy Markdown
Contributor Author

Trying to clear the backlog of PRs. resolved a little conflict and fixed clang format in this branch, trying to see if it clears the CI.

Thanks

@aobolensk

Copy link
Copy Markdown
Contributor Author

@illsilin could you please take a look?

@aobolensk
aobolensk requested a review from illsilin June 30, 2026 10:26
@therock-pr-bot

therock-pr-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled
🤖 therock-pr-bot ✅ Pass

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@illsilin

illsilin commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@illsilin could you please take a look?

running CI right now. so far looking good!

@aobolensk

Copy link
Copy Markdown
Contributor Author

@illsilin could you please guide on the next steps to proceed with merging?

@aobolensk aobolensk changed the title CK: Add SPIR-V target support feat(CK): Add SPIR-V target support Jul 8, 2026
@aobolensk aobolensk changed the title feat(CK): Add SPIR-V target support feat(ck): add SPIR-V target support Jul 8, 2026
@aobolensk

Copy link
Copy Markdown
Contributor Author

@illsilin TheRock PR description check is passing now. Could you please re-trigger math CI?

@geyyer geyyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi folks, thanks for working on it, please hold off from merging it for now.

@aobolensk

aobolensk commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Hi folks, thanks for working on it, please hold off from merging it for now.

@geyyer Are we good to go now?

@geyyer
geyyer merged commit 2c98c10 into ROCm:develop Aug 3, 2026
43 checks passed
assistant-librarian Bot pushed a commit to ROCm/composable_kernel that referenced this pull request Aug 3, 2026
feat(ck): add SPIR-V target support

Add initial support for the amdgcnspirv target in Composable Kernel,
enabling target-agnostic SPIR-V compilation that is JIT-compiled to
native code at runtime

JIRA ID - ROCM-27738

## Motivation

Enable Composable Kernel to compile with the SPIR-V target, producing
target-agnostic SPIR-V binaries that are JIT-compiled to native GPU ISA
at runtime via comgr.

## Technical Details

<!-- Explain the changes along with any relevant GitHub links. -->

## Test Plan

  - Built with GPU_TARGETS=gfx90a;amdgcnspirv
  - Compared wall time (native vs SPIR-V), cold/hot runs

## Test Result

<!-- Briefly summarize test outcomes. -->

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
@amd-hsivasun

Copy link
Copy Markdown
Collaborator

Hi @aobolensk your changes on this PR have caused conflicts on internal side PR: https://github.com/AMD-ROCm-Internal/rocm-libraries/pull/2173. Can you please review this PR and resolve conflicts.

shumway pushed a commit to ROCm/composable_kernel that referenced this pull request Aug 18, 2026
feat(ck): add SPIR-V target support

Add initial support for the amdgcnspirv target in Composable Kernel,
enabling target-agnostic SPIR-V compilation that is JIT-compiled to
native code at runtime

JIRA ID - ROCM-27738

## Motivation

Enable Composable Kernel to compile with the SPIR-V target, producing
target-agnostic SPIR-V binaries that are JIT-compiled to native GPU ISA
at runtime via comgr.

## Technical Details

<!-- Explain the changes along with any relevant GitHub links. -->

## Test Plan

  - Built with GPU_TARGETS=gfx90a;amdgcnspirv
  - Compared wall time (native vs SPIR-V), cold/hot runs

## Test Result

<!-- Briefly summarize test outcomes. -->

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

---------

Co-authored-by: Illia Silin <98187287+illsilin@users.noreply.github.com>
Co-authored-by: illsilin_amdeng <Illia.Silin@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants