feat(ck): add SPIR-V target support - #6304
Conversation
Add initial support for the amdgcnspirv target in Composable Kernel, enabling target-agnostic SPIR-V compilation that is JIT-compiled to native code at runtime
|
@AlexVlx please take a look, I have addressed the comments |
|
Trying to clear the backlog of PRs. resolved a little conflict and fixed clang format in this branch, trying to see if it clears the CI. |
Thanks |
|
@illsilin could you please take a look? |
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
running CI right now. so far looking good! |
|
@illsilin could you please guide on the next steps to proceed with merging? |
|
@illsilin TheRock PR description check is passing now. Could you please re-trigger math CI? |
geyyer
left a comment
There was a problem hiding this comment.
Hi folks, thanks for working on it, please hold off from merging it for now.
@geyyer Are we good to go now? |
feat(ck): add SPIR-V target support Add initial support for the amdgcnspirv target in Composable Kernel, enabling target-agnostic SPIR-V compilation that is JIT-compiled to native code at runtime JIRA ID - ROCM-27738 ## Motivation Enable Composable Kernel to compile with the SPIR-V target, producing target-agnostic SPIR-V binaries that are JIT-compiled to native GPU ISA at runtime via comgr. ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> ## Test Plan - Built with GPU_TARGETS=gfx90a;amdgcnspirv - Compared wall time (native vs SPIR-V), cold/hot runs ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
|
Hi @aobolensk your changes on this PR have caused conflicts on internal side PR: https://github.com/AMD-ROCm-Internal/rocm-libraries/pull/2173. Can you please review this PR and resolve conflicts. |
feat(ck): add SPIR-V target support Add initial support for the amdgcnspirv target in Composable Kernel, enabling target-agnostic SPIR-V compilation that is JIT-compiled to native code at runtime JIRA ID - ROCM-27738 ## Motivation Enable Composable Kernel to compile with the SPIR-V target, producing target-agnostic SPIR-V binaries that are JIT-compiled to native GPU ISA at runtime via comgr. ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> ## Test Plan - Built with GPU_TARGETS=gfx90a;amdgcnspirv - Compared wall time (native vs SPIR-V), cold/hot runs ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Illia Silin <98187287+illsilin@users.noreply.github.com> Co-authored-by: illsilin_amdeng <Illia.Silin@amd.com>
Add initial support for the amdgcnspirv target in Composable Kernel, enabling target-agnostic SPIR-V compilation that is JIT-compiled to native code at runtime
JIRA ID - ROCM-27738
Motivation
Enable Composable Kernel to compile with the SPIR-V target, producing target-agnostic SPIR-V binaries that are JIT-compiled to native GPU ISA at runtime via comgr.
Technical Details
Test Plan
Test Result
Submission Checklist