Add generate_identity_sequences helper and replace lambdas with named functors#4828
Open
tenpercent wants to merge 2 commits intodevelopfrom
Open
Add generate_identity_sequences helper and replace lambdas with named functors#4828tenpercent wants to merge 2 commits intodevelopfrom
tenpercent wants to merge 2 commits intodevelopfrom
Conversation
github-actions
bot
added
External CI
github actions
project: none
tenpercent
force-pushed
the
users/tenpercent/ck/reduce-template-instantiations
branch
from
a058c59 to
11d1d3b
Compare
… functors
## Summary
- Add `generate_identity_sequences<N>()` helper that returns `Tuple<Sequence<0>, Sequence<1>, ..., Sequence<N-1>>`
- Replace lambdas with named functors in `transform_tensor_descriptor`
- Add `unpack_and_merge_sequences` helper functor
- Reduces `transform_tensor_descriptor` instantiations from 388 to 32 (92% reduction)
## Motivation
Multiple call sites use `generate_tuple([](auto i) { return Sequence<i>{}; }, Number<N>{})` pattern. A named helper reduces lambda instantiations.
Additionally, each lambda in `transform_tensor_descriptor` creates a unique closure type, causing the function to be instantiated separately for every call site. Named functors share a single type, so the compiler reuses the same instantiation.
## Changes
### Part 1: generate_identity_sequences helper
- Replaces common lambda pattern for generating identity sequences
- Each lambda expression creates a unique closure type, causing separate template instantiations at every call site
- Named helper shares a single type across all uses
### Part 2: Named functors in transform_tensor_descriptor
- Add `unpack_and_merge_sequences` helper to replace lambda in `GetNumOfHiddenDimension`
- Use `generate_identity_sequences` in `matrix_padder.hpp`
## Test Plan
- Added 7 unit tests:
- 4 tests for `generate_identity_sequences` in unit_sequence_helper.cpp
- 3 tests for `unpack_and_merge_sequences` in unit_tensor_descriptor_functors.cpp
- Added unit_ford test from develop to test/util/CMakeLists.txt
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tenpercent
force-pushed
the
users/tenpercent/ck/reduce-template-instantiations
branch
from
11d1d3b to
776da28
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_identity_sequences<N>()helper that returnsTuple<Sequence<0>, Sequence<1>, ..., Sequence<N-1>>transform_tensor_descriptorunpack_and_merge_sequenceshelper functortransform_tensor_descriptorinstantiations from 388 to 32 (92% reduction)Motivation
Multiple call sites use
generate_tuple([](auto i) { return Sequence<i>{}; }, Number<N>{})pattern. A named helper reduces lambda instantiations.Additionally, each lambda in
transform_tensor_descriptorcreates a unique closure type, causing the function to be instantiated separately for every call site. Named functors share a single type, so the compiler reuses the same instantiation.Changes
Part 1: generate_identity_sequences helper
Part 2: Named functors in transform_tensor_descriptor
unpack_and_merge_sequenceshelper to replace lambda inGetNumOfHiddenDimensiongenerate_identity_sequencesinmatrix_padder.hppTest Plan
generate_identity_sequencesunpack_and_merge_sequencesRelated PRs
This PR merges the functionality from:
Part of PR stack for issue #4229 (Reduce CK/CKTile Build Times)
Note: This PR supersedes #4283, ROCm/composable_kernel#3588 and ROCm/composable_kernel#3589, which can be closed once this is merged.
🔁 Imported from ROCm/composable_kernel#3628
🧑💻 Originally authored by @tenpercent