Fix icache_flush xfail to apply for ROCm 7.1 and above - #3832
Closed
talumbau wants to merge 1 commit into
Closed
Conversation
perfci run on commit 10fb75a |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (43.62%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #3832 +/- ##
========================================
Coverage 43.62% 43.62%
========================================
Files 30 30
Lines 11442 11442
Branches 1440 1440
========================================
Hits 4991 4991
Misses 5984 5984
Partials 467 467
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
talumbau
force-pushed
the
users/talumbau/rocmver72_above
branch
from
January 14, 2026 17:59
5f78a5b to
cdc3397
Compare
perfci run on commit 8c04992 |
Remove duplicate skip logic (from bad merge) and update xfail condition to use version comparison instead of string prefix matching, so the test is properly marked as expected-to-fail on ROCm 7.1, 7.2, and beyond. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
talumbau
force-pushed
the
users/talumbau/rocmver72_above
branch
from
January 16, 2026 17:05
cdc3397 to
3c10706
Compare
perfci run on commit a09993c |
Contributor
|
This pull request has been inactive for 25 days and will be marked as stale. If you would like to keep this PR open, please:
This PR will be automatically closed in 5 days if no further activity occurs. |
Contributor
|
This pull request has been automatically closed due to inactivity (30 days with no updates). If you'd like to continue working on this, feel free to reopen the PR or create a new one. |
JiaLuo-CAN
added a commit
that referenced
this pull request
Jul 15, 2026
…flydsl_mxfp4_gemm1, under run-only mode it needs the mxfp4 cache
JiaLuo-CAN
added a commit
that referenced
this pull request
Jul 15, 2026
…flydsl_mxfp4_gemm1, under run-only mode it needs the mxfp4 cache
JiaLuo-CAN
added a commit
that referenced
this pull request
Jul 16, 2026
…flydsl_mxfp4_gemm1, under run-only mode it needs the mxfp4 cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Remove duplicate skip logic (from bad merge) and update xfail condition to use version comparison instead of string prefix matching, so the test is properly marked as expected-to-fail on ROCm 7.1, 7.2, and beyond.
Technical Details
CI system is starting to test with ROCm 7.2 and we still have the icache flush issue.