Skip to content

fix(rocprim): undeprecated internal use of 'detail::raw_storage' #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stanleytsang-amd merged 1 commit into from
Jun 12, 2025
Merged

fix(rocprim): undeprecated internal use of 'detail::raw_storage' #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions projects/rocprim/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ This is a complete list of affected functions and how their default accumulator
* `rocprim::deterministic_exclusive_scan`
* Previous default: `class AccType = detail::input_type_t<InitValueType>>`
* Current default: `class AccType = rocprim::accumulator_t<BinaryFunction, rocprim::detail::input_type_t<InitValueType>>`
* Undeprecated internal `detail::raw_storage`.

### Deprecations

Expand Down
7 changes: 4 additions & 3 deletions projects/rocprim/rocprim/include/rocprim/detail/various.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,10 +190,11 @@ struct match_fundamental_type
>::type;
};

// A storage-backing wrapper that allows types with non-trivial constructors to be aliased in unions
// A storage-backing wrapper that allows types with non-trivial constructors to be aliased in unions.
// Due to the reinterpret cast, it may in some cases be technically UB, but the generated code is usually
// more performant than proper code.
template<typename T>
struct [[deprecated("To store non default-constructible types in local memory, use "
"rocprim::uninitialized_array instead")]] raw_storage
struct raw_storage
{
// Biggest memory-access word that T is a whole multiple of and is not larger than the alignment of T
using device_word = typename detail::match_fundamental_type<T>::type;
Expand Down