test - #168
Closed
ammallya wants to merge 7 commits into
Closed
Conversation
jayhawk-commits
pushed a commit
that referenced
this pull request
Jun 8, 2025
* Remove website URL from comments (#168) Referencing or using code from some websites is prohibited in this repository. This change removes an informational reference in the comments. * Add gfx1151 build target (#170) (#171) * Add gfx1151 target * Add precheckin.groovy * Add rocRAND dep * Get dep from gfx1151 branch instead of develop * Updated with public develop and set targets to gfx1101 and 1151 * Remove unneeded file for public github * Restore all gpu targets --------- Co-authored-by: Stanley Tsang <stanley.tsang@amd.com> Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com> * Update link to rocRAND data type support (#175) * added gfx12 and gfx1151 to default gpu list * updated changelog * Update CHANGELOG.md Co-authored-by: Jeffrey Novotny <jnovotny@amd.com> * Update CHANGELOG.md Co-authored-by: Jeffrey Novotny <jnovotny@amd.com> * Remove gfx940,gfx941 targets (#191) --------- Co-authored-by: Wayne Franz <Wayne.Franz@amd.com> Co-authored-by: amd-garydeng <garydeng@amd.com> Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com> Co-authored-by: Jeffrey Novotny <jnovotny@amd.com> Co-authored-by: NguyenNhuDi <dinguyennhu@gmail.com> Co-authored-by: Val Movsik <160653499+vamovsik@users.noreply.github.com> [ROCm/hipRAND commit: 8006231]
ammallya
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Defaulting clang-tidy checks to off during rename process * New rules * Descriptors renamed (#135) * New rules * Descriptors renamed * Formatting fixes * rename backend/src/plugin folder (#136) * rename backend/src/plugin folder * fix comments * missed 2 changes * Missed renaming shared library as part of plugins (#139) * Handle Renamed (#134) * rename handles * ignore hipdnnHandle in clang tidy * review comments * rename miopen legacy plugin engines. (#141) * Backend Rename Leftovers (#138) * Performed the rest of the backend renames * Format * PR comments * Renaming in hipdnn_frontend/attributes (#140) Update naming for our new tidy rules * renames for miopen_legacy_plugin/root (#142) * Renaming miopen legacy plugin base dir * fix missed variable and function * Rename sdk plugin (#145) * Rename Engine_config_interface * fix tests * Convert wrappers and test utils * Remaining plugin sdk renames * formatting * Apply formatting * Fix snake_case for last_erorr * Renaming in miopen legacy tests (#143) * first batch of legacy tests * tests set 2 for miopen legacy plugin * missed integration tests, fix small issues * fix * another fix * rename * Rename sdk plugin tests (#148) * Rename sdk/include/hipdnn_sdk/test_utilties symbols and usages (#146) * Rename sdk/include/hipdnn_sdk/test_utilties symbols and usages * Format * Fix test_tensor names * merge conflicts fix * format changes * format --------- Co-authored-by: Brian Harrison <brian.harrison@amd.com> * Update sdk logging names (#147) Co-authored-by: Brian Harrison <brian.harrison@amd.com> * Rename sdk test_utilities tests (#150) * Renaming complete in sdk utilities, tests, and samples. (#149) * Apply formatting * Rename frontend's backend wrappers and helpers (#152) * Renamed frontend's backend wrappers and helpers * Format * Rename backend integration tests (#153) * Rename backend integration tests * formatting * Fix missing rename variable * Renaming frontend/node and base dir (#157) * miopen plugin interface renames (#158) * /backend/tests/ rename (#156) * /backend/tests/ rename * Uncomment * Change global * Rename test plugins (#160) * Rename test plugins for the new naming scheme * Formatting * Fix accidental rename * Camel case for InitialziePlugin * Samples renamed (#159) * Renamed samples * Format * Typo and wrong casing --------- Co-authored-by: Samuel Reeder <samuel.reeder@amd.com> * Frontend integration tests renamed (#161) * Rename sdk tests utilities (#162) * Rename sdk test utilities to match new scheme * Swap to s_ instead of g_ for local static * camelCase * Replace global with test fixture (#163) * Replace global with test fixture * Change name * Rename test internals (#164) * Fix SDK tidy breaks * Backend fixes * More backend and updated clang-tidy for constexpr * Fix tidy errors * More tidy fixes for plugin, sdk, and backend * NOLINT setters and more of frontend * Fix backend tidy error * More frontend fixes * Lint free (by my reckoning) * I did this by hand * Add code style and naming doc (#165) * style doc v1 * add table of contents * fix first batch of comments * review concerns, and new section 14 * add links to style doc from other places * update both cline and copilot instructions to match (#166) * Tidy fixes (#167) * fix a few tidy issues * change tidy to * * Re-enable enum tidies * default tidy back on --------- Co-authored-by: Jeremy Hart <jeremy.hart@amd.com> * fix formatting (#168) --------- Co-authored-by: mousdahl-amd <mitch.ousdahl@amd.com> Co-authored-by: Adam Dickin <adam.dickin@amd.com> Co-authored-by: bibek <108366729+bghimireamd@users.noreply.github.com> Co-authored-by: Jeremy Hart <jeremy.hart@amd.com> Co-authored-by: BrianHarrisonAMD <169072757+BrianHarrisonAMD@users.noreply.github.com> Co-authored-by: Brian Harrison <brian.harrison@amd.com>
ammallya
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Defaulting clang-tidy checks to off during rename process * New rules * Descriptors renamed (#135) * New rules * Descriptors renamed * Formatting fixes * rename backend/src/plugin folder (#136) * rename backend/src/plugin folder * fix comments * missed 2 changes * Missed renaming shared library as part of plugins (#139) * Handle Renamed (#134) * rename handles * ignore hipdnnHandle in clang tidy * review comments * rename miopen legacy plugin engines. (#141) * Backend Rename Leftovers (#138) * Performed the rest of the backend renames * Format * PR comments * Renaming in hipdnn_frontend/attributes (#140) Update naming for our new tidy rules * renames for miopen_legacy_plugin/root (#142) * Renaming miopen legacy plugin base dir * fix missed variable and function * Rename sdk plugin (#145) * Rename Engine_config_interface * fix tests * Convert wrappers and test utils * Remaining plugin sdk renames * formatting * Apply formatting * Fix snake_case for last_erorr * Renaming in miopen legacy tests (#143) * first batch of legacy tests * tests set 2 for miopen legacy plugin * missed integration tests, fix small issues * fix * another fix * rename * Rename sdk plugin tests (#148) * Rename sdk/include/hipdnn_sdk/test_utilties symbols and usages (#146) * Rename sdk/include/hipdnn_sdk/test_utilties symbols and usages * Format * Fix test_tensor names * merge conflicts fix * format changes * format --------- Co-authored-by: Brian Harrison <brian.harrison@amd.com> * Update sdk logging names (#147) Co-authored-by: Brian Harrison <brian.harrison@amd.com> * Rename sdk test_utilities tests (#150) * Renaming complete in sdk utilities, tests, and samples. (#149) * Apply formatting * Rename frontend's backend wrappers and helpers (#152) * Renamed frontend's backend wrappers and helpers * Format * Rename backend integration tests (#153) * Rename backend integration tests * formatting * Fix missing rename variable * Renaming frontend/node and base dir (#157) * miopen plugin interface renames (#158) * /backend/tests/ rename (#156) * /backend/tests/ rename * Uncomment * Change global * Rename test plugins (#160) * Rename test plugins for the new naming scheme * Formatting * Fix accidental rename * Camel case for InitialziePlugin * Samples renamed (#159) * Renamed samples * Format * Typo and wrong casing --------- Co-authored-by: Samuel Reeder <samuel.reeder@amd.com> * Frontend integration tests renamed (#161) * Rename sdk tests utilities (#162) * Rename sdk test utilities to match new scheme * Swap to s_ instead of g_ for local static * camelCase * Replace global with test fixture (#163) * Replace global with test fixture * Change name * Rename test internals (#164) * Fix SDK tidy breaks * Backend fixes * More backend and updated clang-tidy for constexpr * Fix tidy errors * More tidy fixes for plugin, sdk, and backend * NOLINT setters and more of frontend * Fix backend tidy error * More frontend fixes * Lint free (by my reckoning) * I did this by hand * Add code style and naming doc (#165) * style doc v1 * add table of contents * fix first batch of comments * review concerns, and new section 14 * add links to style doc from other places * update both cline and copilot instructions to match (#166) * Tidy fixes (#167) * fix a few tidy issues * change tidy to * * Re-enable enum tidies * default tidy back on --------- Co-authored-by: Jeremy Hart <jeremy.hart@amd.com> * fix formatting (#168) --------- Co-authored-by: mousdahl-amd <mitch.ousdahl@amd.com> Co-authored-by: Adam Dickin <adam.dickin@amd.com> Co-authored-by: bibek <108366729+bghimireamd@users.noreply.github.com> Co-authored-by: Jeremy Hart <jeremy.hart@amd.com> Co-authored-by: BrianHarrisonAMD <169072757+BrianHarrisonAMD@users.noreply.github.com> Co-authored-by: Brian Harrison <brian.harrison@amd.com> [ROCm/hipDNN commit: 839cf6c]
evetsso
pushed a commit
to evetsso/rocm-libraries
that referenced
this pull request
Dec 31, 2025
…90925 rebasing from develop snapshot 090925
3 tasks
SreecharanGundaboluAMD
added a commit
that referenced
this pull request
May 26, 2026
## Motivation This PR adds `gfx1250` support for **miopen** brining in changes from `gfx1250` branch to `develop`. ## Original Commits The following 75 commits from `gfx1250` are included: <details> <summary>View all 75 commits</summary> | Commit | Author | Date | Message | |--------|--------|------|----------| | e6b719a | Choudhary, Rahul | 2026-04-20 | Gfx1250 develop slice 04 (#1195) | | 622fa63 | a1-rocm-devops_amdeng | 2026-04-20 | Merge branch 'gfx1250' into gfx1250-develop-slice-04 | | 8e86859 | Sivasuntharampillai, Haresh | 2026-04-15 | Develop Merge into GFX1250 (#1176) | | 84ac4fb | Gundabolu, Sree Charan | 2026-04-15 | [mi450] Enable Extra warp sync types (#1092) | | 8ba0569 | a1-rocm-devops_amdeng | 2026-04-15 | Merge branch 'gfx1250' into gfx1250-develop-slice-02 | | b60e2ca | Sivasuntharampillai, Haresh | 2026-04-10 | Merger auto-merge-rocm-libraries-develop-to-gfx1250-787 into gfx1250-compute-external-merge-new-787 (#949) | | c2b7e0a | Christina, Jenifer | 2026-04-03 | Merge branch 'gfx1250' into auto-merge-rocm-libraries-develop-to-gfx1250-787 | | fddc0a4 | Gundabolu, Sree Charan | 2026-04-02 | [miopen] fix ck targets bug (#1089) | | c4fee07 | a1-rocm-devops_amdeng | 2026-03-18 | Merge branch 'gfx1250' into auto-merge-rocm-libraries-develop-to-gfx1250-787 | | 56dcfbe | Choudhary, Rahul | 2026-03-17 | Merger auto-merge-rocm-libraries-develop-to-gfx1250-768 into gfx1250-compute-external-merge-new-768 (#815) | | c893ae6 | Silin, Illia | 2026-03-13 | Merge branch 'gfx1250' into auto-merge-rocm-libraries-develop-to-gfx1250-768 | | f593ef4 | Gundabolu, Sree Charan | 2026-03-11 | [miopen] Cleanup, clang-format fix, re-enable fusion solvers (#893) | | 628de4e | a1-rocm-devops_amdeng | 2026-03-06 | Merge remote-tracking branch 'origin/gfx1250' into auto-merge-rocm-libraries-develop-to-gfx1250-768 | | 2621228 | Sivasuntharampillai, Haresh | 2026-02-25 | Merger auto-merge-rocm-libraries-develop-to-gfx1250-745 into gfx1250-compute-external-merge-new-745 (#724) | | 8b78e71 | Gundabolu, Sree Charan | 2026-02-25 | Merge branch 'gfx1250' into auto-merge-rocm-libraries-develop-to-gfx1250-745 | | 6ece737 | Uphoff, Carsten | 2026-02-25 | Fix gcn_reduce for gfx1250 and wave size 32 (#727) | | 7031baf | a1-rocm-devops_amdeng | 2026-02-17 | Merge branch 'gfx1250' into auto-merge-rocm-libraries-develop-to-gfx1250-745 | | 292d919 | Choudhary, Rahul | 2026-02-09 | Merger auto-merge-rocm-libraries-develop-737 into gfx1250-compute-external-merge-new-737 (#664) | | f526087 | Sivasuntharampillai, Haresh | 2026-02-06 | Merge branch 'gfx1250' into auto-merge-rocm-libraries-develop-737 | | 2be0ac1 | Gundabolu, Sree Charan | 2026-01-29 | remove Winograd support for gfx125x (#656) | | 5bcc357 | Choudhary, Rahul | 2026-01-26 | Merger auto-merge-rocm-libraries-develop-734 into gfx1250-compute-external-merge-new-734 (#650) | | 81284af | Choudhary, Rahul | 2026-01-23 | Merger auto-merge-rocm-libraries-develop-730 into gfx1250-compute-external-merge-new-730 (#641) | | f291150 | Sivasuntharampillai, Haresh | 2026-01-22 | Merge branch 'gfx1250' into auto-merge-rocm-libraries-develop-730 | | a75361c | Sivasuntharampillai, Haresh | 2026-01-21 | Merge pull request #632 from AMD-ROCm-Internal/auto-merge-rocm-libraries-develop-727 | | 2f66954 | Henderson, Nathan | 2026-01-19 | Merge remote-tracking branch 'origin/gfx1250' into auto-merge-rocm-libraries-develop-727 | | 4554323 | Sivasuntharampillai, Haresh | 2026-01-16 | Merge pull request #617 from AMD-ROCm-Internal/auto-merge-rocm-libraries-develop-723 | | 9f1e78f | Gundabolu, Sree Charan | 2026-01-15 | Merge branch 'gfx1250' into auto-merge-rocm-libraries-develop-723 | | 578b3a5 | Sivasuntharampillai, Haresh | 2026-01-15 | Fix leading whitespace in backward_per_activation_fused.cpp (#602) | | 5e63aa6 | Sivasuntharampillai, Haresh | 2026-01-15 | Merge pull request #603 from AMD-ROCm-Internal/auto-merge-rocm-libraries-develop-721 | | 8ee7d9b | Joao P. L. de Carvalho | 2026-01-13 | Merge remote-tracking branch 'origin/gfx1250' into auto-merge-rocm-libraries-develop-721 | | 458d1d4 | Sivasuntharampillai, Haresh | 2026-01-12 | Merge pull request #596 from AMD-ROCm-Internal/auto-merge-rocm-libraries-develop-717 | | 5874b52 | Joao P. L. de Carvalho | 2026-01-09 | Merge remote-tracking branch 'origin/gfx1250' into auto-merge-rocm-libraries-develop-717 | | c4acfdd | Sivasuntharampillai, Haresh | 2026-01-09 | Merge pull request #565 from AMD-ROCm-Internal/auto-merge-rocm-libraries-develop-715 | | 48df659 | hsivasun_amdeng | 2026-01-08 | Merge branch 'gfx1250' into auto-merge-rocm-libraries-develop-715 | | 0f8aa29 | Sivasuntharampillai, Haresh | 2026-01-07 | Merge pull request #583 from AMD-ROCm-Internal/auto-merge-rocm-libraries-develop-686 | | 1b18743 | hsivasun_amdeng | 2026-01-07 | Revert "Merger auto-merge-rocm-libraries-develop-686 into gfx1250-compute-external-merge-new-686 (#502)" | | d58a75d | rocm_devops, a1 | 2025-12-24 | Merger auto-merge-rocm-libraries-develop-686 into gfx1250-compute-external-merge-new-686 (#502) | | 78c5a6a | hsivasun_amdeng | 2025-12-19 | Resolve conflicts | | e595abf | Sivasuntharampillai, Haresh | 2025-12-16 | Merge pull request #475 from AMD-ROCm-Internal/auto-merge-rocm-libraries-develop-678 | | 972e06e | Choudhary, Rahul | 2025-12-09 | Merge pull request #466 from AMD-ROCm-Internal/auto-merge-rocm-libraries-develop-673 | | 2c89689 | Gundabolu, Sree Charan | 2025-12-07 | Revert "MIOpen:feature:tf32:demonstrate tf32 in conv3d on MI30X platform (#1414)" (#486) | | f7d7abf | Choudhary, Rahul | 2025-12-04 | Merge branch 'gfx1250' into auto-merge-rocm-libraries-develop-673 | | 1cbaf5d | Choudhary, Rahul | 2025-12-04 | Comment out composable_kernel dependency for npi conflict | | 6e812f0 | Caio Salvador Rohwedder | 2025-12-04 | Merge remote-tracking branch 'origin/gfx1250' into auto-merge-rocm-libraries-develop-678 | | ee904c2 | Choudhary, Rahul | 2025-12-02 | Merge pull request #443 from AMD-ROCm-Internal/auto-merge-rocm-libraries-develop-664 | | dc333a6 | Choudhary, Rahul | 2025-11-25 | resolving develop to npi merge conflcit | | 4ce9ecd | Choudhary, Rahul | 2025-11-25 | Fix merge conflict in requirements.txt, ck hash not needed in npi | | d82ab7b | Joao P. L. de Carvalho | 2025-11-19 | Merge remote-tracking branch 'origin/gfx1250' into auto-merge-rocm-libraries-develop-664 | | 6006f54 | Choudhary, Rahul | 2025-11-17 | Merge pull request #361 from AMD-ROCm-Internal/auto-merge-rocm-libraries-develop-632 | | 53031dd | hsivasun_amdeng | 2025-11-06 | Fix remaining MIOpen Files | | d7f8ba9 | hsivasun_amdeng | 2025-11-06 | Fix MIOpen File | | ea6ae17 | hsivasun_amdeng | 2025-11-06 | Fix Conflicts | | 25e4fcd | Choudhary, Rahul | 2025-10-28 | Merge pull request #356 from AMD-ROCm-Internal/rahulc/develop_snapshot_1002_69082b | | 95b8027 | hsivasun_amdeng | 2025-10-23 | Resolve merge conflicts in hipblaslt and hipsparselt files | | daf8693 | Choudhary, Rahul | 2025-10-20 | Merge pull request #350 from AMD-ROCm-Internal/rahulc/develop_pre_hipDNN_snapshot_0924_84fe628 | | 5562e40 | Choudhary, Rahul | 2025-10-20 | Merge branch 'rahulc/gfx1250_reverted_PR148_9118d8adbe' into rahulc/develop_pre_hipDNN_snapshot_0924_84fe628 | | 2ef828d | Choudhary, Rahul | 2025-10-15 | Merge pull request #345 from AMD-ROCm-Internal/rahulc/develop_snpashot_091825 | | b1952f3 | hsivasun_amdeng | 2025-10-15 | Resolve merge conflict by incorporating changes from split PRs 299, 301, 302, 303,309, 314 | | bc31bc9 | Choudhary, Rahul | 2025-10-14 | Merge pull request #341 from Auto merge rocm libraries develop 595 resolve hipblaslt rocblas conflicts | | 38e58b3 | Choudhary, Rahul | 2025-10-14 | Merge pull request #336 from AMD-ROCm-Internal/auto-merge-rocm-libraries-develop-590 | | 1eb4135 | Choudhary, Rahul | 2025-10-14 | Merge pull request #335 from AMD-ROCm-Internal/develop_snapshot_090925 | | a18958e | Choudhary, Rahul | 2025-09-18 | Merge pull request #183 from AMD-ROCm-Internal/auto-merge-rocm-libraries-develop-595-resolve-hipblaslt-rocblas-conflicts | | 2d78484 | jichang | 2025-09-17 | Merge branch 'gfx1250' into auto-merge-rocm-libraries-develop-595 | | d13e390 | Choudhary, Rahul | 2025-09-11 | Merge pull request #171 from AMD-ROCm-Internal/auto-merge-rocm-libraries-develop-590 | | 84284d1 | Choudhary, Rahul | 2025-09-11 | Merge branch 'gfx1250' into auto-merge-rocm-libraries-develop-590 | | 90c7822 | Choudhary, Rahul | 2025-09-10 | Merge pull request #168 from AMD-ROCm-Internal/develop_snapshot_090925 | | bd50e7c | Choudhary, Rahul | 2025-09-10 | Merge branch 'new-gfx1250-from-develop-082125' into develop_snapshot_090925 | | 2040c29 | Choudhary, Rahul | 2025-08-26 | Merge pull request #148 from AMD-ROCm-Internal/rahchoud_amdeng-patch-8 | | 9118d8a | Gundabolu, Sree Charan | 2025-08-26 | Fix path to CK in requirements.txt | | b9eec8b | rahchoud | 2025-08-26 | adding gfx1250 specific changes | | 7d9dca0 | Choudhary, Rahul | 2025-08-25 | Update MIOPEN_USE_AMDGCN definition for GFX125X | | 3f8c33a | Choudhary, Rahul | 2025-08-25 | Update MIOPEN_USE_AMDGCN definition condition | | 3b86bbb | Choudhary, Rahul | 2025-08-25 | Update AMDGCN condition for MIOPEN_USE_AMDGCN | | 07aa109 | Choudhary, Rahul | 2025-08-25 | Update MIOPEN_USE_AMDGCN condition for compatibility | | 85a34ac | Choudhary, Rahul | 2025-08-25 | [miopen] adding gfx1250 target and related changes | </details> ## Test Plan - [x] Can be built locally. - [x] Passes CI. ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.