Skip to content

Revert "fix(ck): prevent int32 overflow in tensor descriptor element space size" (#10547) - #10947

Closed
ozturkosu wants to merge 1 commit into
developfrom
users/muozturk/ck/revert-10547
Closed

Revert "fix(ck): prevent int32 overflow in tensor descriptor element space size" (#10547)#10947
ozturkosu wants to merge 1 commit into
developfrom
users/muozturk/ck/revert-10547

Conversation

@ozturkosu

Copy link
Copy Markdown
Contributor

Revert of #10547

Reverts #10547 ("fix(ck): prevent int32 overflow in tensor descriptor element space size", squash commit 235faade) on develop, per team direction due to a CI test failure introduced by that change.

⚠️ Important — this re-opens a security fix

#10547 fixed ROCM‑29071 (bug-bounty): a signed int32 overflow in calculate_element_space_size_impl() / make_naive_tensor_descriptor() that causes an out-of-bounds GPU write (CWE‑787) in grouped conv bwd-weight when K·C > INT32_MAX. Reverting restores that vulnerability.

A re-fix must follow — track under ROCM‑29071. The original fix's own note explains the constraint (a blanket static_cast<long_index_t> broke the gfx950/gfx1201/Windows math-libs build by flipping IsKnownAtCompileTime() to false; the merged version used widen_runtime_index_to_long() to widen only runtime operands). The re-fix should preserve that behavior while resolving the CI test failure that triggered this revert.

Files reverted

  • include/ck/tensor_description/tensor_descriptor_helper.hpp
  • test/util/CMakeLists.txt
  • test/util/unit_tensor_descriptor_element_space_size.cpp (removed)

cc the ROCM‑29071 owners.

@therock-pr-bot

therock-pr-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/composablekernel/include/ck/tensor_description/tensor_descriptor_helper.hpp; no test file found
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled
🤖 therock-pr-bot ✅ Pass

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@ozturkosu
ozturkosu enabled auto-merge (squash) August 18, 2026 17:14
@ozturkosu ozturkosu self-assigned this Aug 18, 2026
@JiaLuo-CAN

Copy link
Copy Markdown
Contributor

Close the revert PR. Fixes required has been done in PR #10043.

@JiaLuo-CAN JiaLuo-CAN closed this Aug 18, 2026
auto-merge was automatically disabled August 18, 2026 23:48

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants