Suggestion Description
Various ROCm components set ROCM_USE_FLOAT16 at the CMake level. While there may be a case to handle it at the CMake level in some cases, leveraging a header-only implementation that sets the definition based on system inspection may be a more consistent and scalable approach. Alternatively (or additionally), an approach that leverages check_cxx_source_compiles could be used to check if _Float16 is supported for the requested compiler.
Fundamentally, this definition shouldn't be added unconditionally to CMake targets; there should be a more correct and consistent approach that reduces how often ROCM_USE_FLOAT16 is copy-pasted throughout the code based to get builds working.
Operating System
No response
GPU
No response
ROCm Component
No response
Suggestion Description
Various ROCm components set ROCM_USE_FLOAT16 at the CMake level. While there may be a case to handle it at the CMake level in some cases, leveraging a header-only implementation that sets the definition based on system inspection may be a more consistent and scalable approach. Alternatively (or additionally), an approach that leverages
check_cxx_source_compilescould be used to check if_Float16is supported for the requested compiler.Fundamentally, this definition shouldn't be added unconditionally to CMake targets; there should be a more correct and consistent approach that reduces how often ROCM_USE_FLOAT16 is copy-pasted throughout the code based to get builds working.
Operating System
No response
GPU
No response
ROCm Component
No response