Remove toggle-primary-sidebar #1271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinning the pydata-sphinx-theme dep to a version before this bug was introduced executablebooks/sphinx-book-theme#865 The fix seems to work and lgtm... @alexxu-amd are you good with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #1270
The issue reports the sidebar button becomes misaligned with the header/breadcrumbs. I've also seen this in a couple different repos. Here's an example from the ROCdbgapi portal.
What's weird is that when the sidebar button is correctly aligned, it toggles the sidebar on and off. When the toggle-primary-sidebar button is misaligned and clicked, it opens a seperate windowed sidebar rather than toggling the existing one.
This PR disables the button entirely for the time being.
EDIT: The behaviour changing when misaligned is related to executablebooks/sphinx-book-theme#865