TEST: Windows googlebench ci fix #293
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of an ad-hoc reporting format, use the googlebenchmark library to define, filter and execute benchmarks. Custom context information is also added to the benchmark for archival reasons similar to rocPRIM. Googlebenchmark is automatically downloaded if not found when benchmarks are enabled.
…test The hip headers have device only code visible to the host compiler on the nvcc path. Package test is compiled with just the host compiler because its only using the host api of rocrand. This workaround sets it to CUDA mode in the nvcc path until the fix for hip headers is released. Modernize to CUDA language instead of FindCuda.cmake.
The underlying issue has been fixed in latest rocm-cmake.
On some distributions (notable ones include alpine and nixos) `bash` is not part of the base installation, therefore its not installed in `/bin`. Use `env` to find bash in the `PATH` which is portable on most *nix systems.
Restore the old `bencmark_rocrand_generate` for backwards compatibility. Add the googlebenchmark based version as `benchmark_rocrand_host_api`. Building the old benchmark can be enabled by setting `BUILD_LEGACY_BENCHMARK` to `ON` (on by default). A later change can change the default and then finally remove the old benchmarks giving users time to adjust to the changes.
The underlying issue has been fixed in v1.5.5 with google/benchmark#1174. The workaround is no longer needed.
stanleytsang-amd
force-pushed
the
windows_googlebench_ci_fix
branch
from
5f87913 to
d4338c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge