Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edited to conform to standards #617

Open
wants to merge 1 commit into
base: release/rocm-rel-6.2
Choose a base branch
from

Conversation

spolifroni-amd
Copy link
Contributor

No description provided.

@peterjunpark
Copy link
Contributor

peterjunpark commented Oct 8, 2024

Hi @stanleytsang-amd, shouldn't your version string be at least "3.2.1" in the release branch at this point? -- And now "3.2.2" for the upcoming ROCm 6.2.4 release?

set(VERSION_STRING "3.2.0")

Your changelog in the release branch says

rocPRIM-3.2.1 for ROCm 6.2.1

Kinda confusing

@stanleytsang-amd
Copy link
Collaborator

Hi @stanleytsang-amd, shouldn't your version string be at least "3.2.1" in the release branch at this point? -- And now "3.2.2" for the upcoming ROCm 6.2.4 release?

set(VERSION_STRING "3.2.0")

Your changelog in the release branch says

rocPRIM-3.2.1 for ROCm 6.2.1

Kinda confusing

Hi, yes you are correct. It has been updated now in the 6.2 release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants